If I could work out what to install Iād give it a run aroundā¦ can I get a linky for us non-gits and Iāll attempt to break if for you. Pressed loads of buttons and worked it out. Will let you know if I break it.
Edited to add: Button is back!! Woo!! and Yay!! Happily appears on a 1CD or a 10CD album without care. Quick tested a few disambigs to see if it works. Nothing exploded. Happy on Vivaldi \ Violent Monkey \ Windows.
I did the test changes on a four disc album. It was more the fact the button appeared and stayed on screen was the key on the 10CD album. So no regression.
The fix has been merged this weekend and since there have been no complaints about issues with other browser setups, I would consider this as solved for ānormal releasesā.
Regarding the usage for medium 11+ on bigger releases I am not even sure if this had ever worked (or I never needed this script for such a medium which is collapsed by default). The trick @ulugabi mentioned should help in these cases, right now every(?) userscript which I am using seems to struggle with these dynamically loaded mediums and a thorough fix would require more work.
The following from the script would seem to stop the script from running when when adding ā/disc/6ā for the workaround. Itās actually working for some people? @exclude *musicbrainz.org/release/*/*
I can say I havenāt yet found a way to use this script for disc >5 using Firefox + Tampermonkey.
Ah yes of course.
The work-around is only a work-around to enable the script for all the tracks of 1 particular medium. A medium that would otherwise be ignored as being collapsed.
Right. I installed the version with the pull request included. I added ā/disc/4ā to the URL. I clicked the button to show the comment boxes. They were already populated with the comments from another medium (medium 3, I think). The script got a little confused, and boxes were not red that should be (it thought the comment was not changed, even though it was a new comment). Still, it did seem to set the comments on all of the recordings.
Also, if I recall correctly, after setting the comments, if I loaded it the same way again, it would have the comments from another medium again, rather than the actual comments.
I guess a proper fix would be the better solution, so I created a PR instead:
This time I would like more people to test or review this before I will merge it
(The last time I only checked whether the script was loading any comments, but I did not verify whether these were for the correct recordings. For this PR I actually did an editing test with @ulugabiās example release on the test server and it worked.)
Sorry for braking this, without testing more than the mere display.
Hopefully it only breaks when using that quite obscure hardly known work-around (which is not even a work-around, as it never could have worked without your change, @kellnerd).
Iām not sure what youād like me to test. Using middle-/control-click just opens the same URL as typing it in. The results from the script are the same either way.
The middle-click trick is just a shortcut which spares you from manually changing the URL, it does not have any effect on how the userscript behaves.
We would like you to test the (hopefully) fixed version of the userscript (install link for the above PR) with your multi-disc release before the changes will be published for all users.