ROpdebee's userscripts support thread

Tags: #<Tag:0x00007fd2e59a09b0>

And this is why I added @kellnerd as a collaborator to the repo :slight_smile:

// Violentmonkey: script is not running at all

Can you clarify that? I assume you meant GreaseMonkey? Is the Enhanced CAA script not running on GreaseMonkey at all? That would be…bad

3 Likes

Yes, of course I meant Greasemonkey, the classical copy-paste error :flushed:
I guess it is related to the GM_* functions too, they are called GM.* there. Violentmonkey supports both styles and Tampermonkey only the first one:

But to be honest, since I often had problems with many MusicBrianz userscripts under Greasemonkey since their rewrite for version 4, I am no longer using it and also have not tested my userscripts with it. So far there has been a single complaint.

There’s a polyfill for the new API, but I’ve never used it. Might be worth a try, but since most other userscripts don’t support GM4 either, it’s not a priority.

Just noticed that it doesn’t seem possible to paste multiple URLs in Enhanced Cover Art Uploads.
And I guess URL decoding would be nice:


“Paste multiple external links at once” seems to conflict with “Create entity or fill data from wikipedia / wikidata / VIAF / ISNI” by @loujin:

  • Uncaught TypeError: Object.getOwnPropertyDescriptor(...) is undefined
  • Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'set')
2 Likes

About Qobuz. Maybe there is hope.
I have found something at:
https://open.qobuz.com/album/0825646089178

The goodies were right there unguarded and I just couldn’t resist


A teeny tiny bit got archived:

2 Likes

Where, exactly? I’m not seeing any goodies on that page.

Watch the network log :wink:
https://www.qobuz.com/api.json/0.2/album/get?album_id=0825646089178&offset=0&limit=20

app_id (X-App-Id) is also part of request

2 Likes

Derp, when adding PDFs “Display CAA image dimensions” (2021.9.13) displays an image size:

1 Like

We can haz 7digital cover provider? No hi-res images but better than nothing.
A key might not be necessary if the URLs can be guessed that easily:
https://de.7digital.com/artist/tu-ves-ovnis/release/curva-al-final-del-t%C3%BAnel-14385941http://artwork-cdn.7static.com/static/img/sleeveart/00/143/859/0014385941_800.jpg

1 Like

First of all, thank you for this amazing script!
It makes my life a lot easier!

Just tested the import button for vgmdb and it seems to fetch only certain image types
Tried with this release Majo no Takkyuubin Image Album | TKCA-71030 - VGMdb and the images for types obi and insert weren’t fetched, had to manually add them.

1 Like

@chaban mentioned previously that you need to log in to see all images, but I was under the impression that the 3rd-party vgmdb.info API provided all the covers. Evidently that isn’t the case. Unfortunately, as mentioned previously, I have no intention to support anything requiring authentication so those images won’t be able to be grabbed unless you manually enter the direct links.

I’m wondering why these images require an account to access, though, so if anyone has any info (or possibly even a workaround), please share. If we could somehow detect when images are missing, we could warn about it though. It appears that this table displays the correct number of covers and doesn’t require an account to access. However, extracting that information in an automated way would be fairly inefficient, as there doesn’t seem to be a way to get that information for a specific album in a single request, we’d need to traverse that whole list. It’s possible to run a binary search but that would still require around 6 network requests for releases starting with M and a page size of 100. Admittedly that’s much better than 251 requests in the worst case with a simple linear scan, but it’s still quite a lot of requests…

I’ve created #62 to track, but I don’t expect this to get fixed in the near future. I’ll try to get in touch with the people behind the 3rd-party API and see if we can do anything about it.

2 Likes

Thanks for your quick reply!

Yeah, it seems that getting all the covers without account support won’t be possible at the moment.
I do wonder why they choose to lock stuff like Obi. I do understand why they would lock R18 cover art tho.

It seems that the usual cover art types available without account support are: Front, Back, Booklet and Medium. Anything extra seems to be locked, but the images themselves can still be reached without an account, since copying the url to upload them works and I can also open the url in an incognito tab without logging in.

I like the idea of warning about “incomplete” uploads too, but I understand it could be tiresome to fix in the near future.

Since the direct links to images themselves can be accessed without an account, a possible option would be to run a userscript (either the main script itself or a smaller standalone one) on VGMdb and somehow extract the links there. If the user is logged in, that script will be able to extract all images. The links could then either be put inside of a text box and copied to the clipboard (requires #53 to be addressed) or we could add a button to “seed” them directly to the addition page, like what’s being done on a-tisket currently. The latter could make it easier to automatically fill types and comments, but would require 1) being able to seed multiple links (currently not supported, but should be viable) and 2) link VGMdb albums to MB releases (which should be possible).

2 Likes

I don’t know if there’s an userscript like that available, but, until now I used a small python script that downloaded all the images and then I just uploaded them to the CAA using the regular uploader option. It did require login tho.

It might be possible to tweak it to extract all the URLs and output them to text

2 Likes

A few more suggestions for Enhanced cover art uploads:

2 Likes

Apologies for the radio silence over the past couple of weeks, I’d mostly been working behind the scenes to make the userscripts and the development process more reliable, and most of that is now done. In the meantime I’ve released a couple of fixes to various userscripts:

  • CAA Dimensions will properly handle queued PDF uploads on add-cover-art pages (thanks chaban!)
  • Collapse Work Attributes should now run on other pages of artist works on all browsers and userscript engines. Previously it worked on ViolentMonkey, but not on TamperMonkey. (thanks Tiske Tisja).
  • The incompatibility between Paste Multiple External Links and louijin’s Wikipedia/Wikidata/VIAF/ISNI script has been fixed on loujin’s side.
  • Enhanced Cover Art Uploads:
    • open.qobuz.com links are now supported.
    • Qobuz goodies are extracted when available.
    • Improved extraction of Tidal covers
    • Optimised extraction of Discogs covers
    • We’ve changed the way we’re seeding covers through URLs (e.g. on a-tisket), which opens up possibilities to address the VGMdb issue of covers hidden behind a login.
    • URL redirects are handled more safely.
      • Redirects in all providers are checked to ensure that we get redirected to the same release as the original URL (think iTunes to Apple Music URLs), if not, the extraction is aborted with an error. You can then choose to use the target URL directly.
      • Redirects in direct image links are still allowed, but will emit a warning and will be indicated in the edit note.
      • Known issues:
        • Those warnings get overwritten in the status banner quite quickly.
        • The redirect error message for providers is very long and leads to bad placement of page elements.
        • Both of these will be fixed by #81
    • Various other small fixes and improvements.

@kellnerd is also currently working on fixing the Amazon provider (#86), which is currently missing some images if there’s more than 4, and also isn’t extracting the highest possible resolution. Those fixes should get automatically released once we merge that PR (like this), thanks to the behind-the-scenes changes. So you can expect plenty more regular updates without waiting on me to decide when a new version should be released :slight_smile:

Edited to add: I could use some additional input on this Apple Music PNG/JPEG issue, if anyone knows something about image compression etc.

5 Likes

I’ve tried to install in both Chrome and Brave, but both times, I get an “Invalid Script Header” error am I doing something wrong? I do have it in developer mode

@DemonKingOdio Make sure you’re installing it through a userscript engine like Tampermonkey or Violentmonkey and not as a native Chrome userscript. Native Chrome userscripts are severely limited in functionality.

3 Likes

More suggestions, bugs and observations using Enhanced Cover art uploads:

Trivia:
Some Deezer releases have a placeholder cover:

The 5-track version which is also available on Deezer has the right cover.

It’s not just Deezer, Napster seems to have similar problems sometimes:

Statistics:
Does the script make an impact on cover art additions? It seems so:

(For reference: the script was announced in the forum on 2021-09-22 and ca. 2021-10-13 when I started mass adding cover art, thanks holesovice)

You can’t really see the numbers at the end, zoom out to watch them soaring up to 1,000 per day.

Let’s compare releases with cover art to releases in the db:

Amazing, are cover art and release adders playing catch? :stuck_out_tongue:

5 Likes

Quick reply, I’ll look into it in more detail in the near future.

  • I thought I had fixed those “r: HTTP error” problems, will look into it again. Will look into the Deezer problem with missing status text too. Update: Fixed

Add warnings from “Supercharged cover art uploads edits” such as releases in the future or unusual aspect ratio for packaging/format

  • In the edit note or on the page itself? Could be useful, but would be much easier to implement if Supercharged were ported, which it isn’t yet. I’ll see what I can do in the meantime.
  • About the duplicate track images: We were already aware of this but didn’t think it’d be that common (that’s a pretty big list, given that this change has only been out for 2 days). We actually are deduplicating the track images, but we’re basing that on the URL. In your first example, although all track images are identical (and identical to the front cover too), each of them has a different URL. I ran into the same issue with Soundcloud (not released yet), where we’ll deduplicate based on thumbnail data. I’ll investigate for Bandcamp too. What I can already say is that the case where the resolution and AR differs, that there’s nothing that can be done about it, other than running the image diffing algorithm from Supercharged on all of the track images, which isn’t really feasible to do for every image (very resource-intensive). #13 should make it easier to compare those cases, but that also requires the Supercharged port.
  • Image type and index in the filename is intentional: The index is used to uniquely identify the image when filling in types and comments; the extension is there because some providers may use the “png” suffix while serving JPEGs etc. We could clean that up a bit, though.
  • Placeholder covers: I’ll see if I can filter those out. We already do this for Amazon. Some more trivia on 7digital: If you go to a non-existent image, it’ll redirect you to the placeholder (e.g. https://artwork-cdn.7static.com/static/img/sleeveart/00/102/949/001029492_350.jpg)
  • Update: The messaging w.r.t. missing Bandcamp covers and deleted Apple Music releases has been improved.

As for whether the script has an impact on cover art additions: it think it does. I’ve done some DB queries for the edit note content, I found 14956 edit notes containing “Enhanced Cover Art Uploads”. Snapshot from yesterday, so it’s likely over 15k by now. On average, that’s about 483 covers added by the script per day. For reference, scanning for “Upload to CAA from URL” gives ~16800 results, since 2021-06-02. Assuming everyone switched to Enhanced when it came out, that’s only 150/day on average.


Since I’m here anyway, short summary of the most important changes in the past week:

  • The previously-mentioned Amazon issue has been fixed (thanks @kellnerd!)
  • Seeding from a-tisket works on Tampermonkey again
  • We’re now grabbing Apple Music JPEG version if the source format was JPEG
  • Bandcamp track images and square thumbnails are grabbed when applicable
  • You can now paste multiple URLs separated by whitespace, and the issue with URL decoding has been addressed
  • Added QUB Musique provider (basically the same as Qobuz)
  • Added 7digital provider
  • Added Melon provider
  • We’ve updated the location of the “Supported providers” document, so if you have that bookmarked, please update. The old URL should continue to work for a while, but at some point it’ll probably get binned.
  • Various BTS changes and improvements.
  • “Select All Update Recordings” is now enabled on “add release” pages too (thanks @jesus2099!)

Coming soon Now here:

  • Support for Soundcloud (+ track images, deduplicated where possible)
  • Support for Beatport (beware of upscaled images, they’re common on old releases)

If you’ve got other providers that you’d like to see added, let me know! :slight_smile:

4 Likes