Notes from #MetaBrainz Meeting 2021-09-20

[Freso]

MetaBrainz Meeting 2021-09-20

Meeting start: IRC Logs for #metabrainz | MetaBrainz Chatlogs

International Monday of University Sport

"Weird Al" Yankovic - Sports Song (Official 4K Video)

Agenda

• Reviews
• Invoices
• Dead link collection

Last meeting: 2021-09-13
Next meeting: 2021-09-27

Reviews

@yyoung

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yyoung

• Last week I finished implementation of MBS-11919 and MBS-11978, now working on MBS-11901.
• That’s all, thank you.

@reosarevok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

Last week I worked quite a bit on extending the artist page filters for release groups
(MBS-8186 and MBS-11950)
Also some smaller things, stuff like MBS-10056
This week I’ll concentrate on getting stuff ready for beta release, but I might look into better sir tests now that lucifer got that working? I’ll see how the week goes

@ApeKattQuest_MonkeyPython

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@ApeKattQuest_MonkeyPython

sadface in that unfortunately New Browser™:sparkles: didn’t work out, there is still one webextension(?) (old ff) addon that will not work in the new one (and it was one i’m absolutely dependant on for instrument adding work :​/)
in better news, other endeavours are going swimmingly!
I also added a lot of books to bb, will try to get all the tickets i’ve been writing in notes onto jira!
finally i helped reo find a privacy tag issue that he fixed :​D MBS-11976

@zas

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@zas

I did usual maintenance, upgrades
also reviewed Picard PRs
I finished and tuned prometheus node exporter deployment

@bitmap

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@bitmap

last week I spent some time testing replication locally for dbmirror2 support by mwiencek · Pull Request #2248 · metabrainz/musicbrainz-server · GitHub & hope to set that up for test.mb this week. have not noticed any issues locally so far
I worked on a lot more on the batch-add-relationships and batch-create-works dialogs in the new relationship editor code. the latter has been modified to support multiple work languages
this is one of the last big pieces remaining though, at least
otherwise I did a bit of code review / merging earlier in the week.

@yvanzo

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yvanzo

Last week I reviewed a fair amount of MBS PRs for the release scheduled for the 4th of October.
Also implemented and deployed threads limitation for MB dump builders.
Plus worked on smaller issues, restored SIR, support, triage…
I will join monkey and the Barceloners on Wednesday for half-work half-vacations.
I will be less available for about two weeks.
Also planning for another move shortly after the MeB Summit.

@mr_monkey

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@mr_monkey

Last week I worked with @rob to add a new page to Listenbrainz to see the tracks you liked/hated:
It is currently deployed on test.lb if you want to have a look:
https://test.listenbrainz.org/user/mr_monkey/feedback/
I finished a new feature for LB to submit tracks listened to on the LB website:
LB-606: Submit listens when playing music with BrainzPlayer by MonkeyDo · Pull Request #1608 · metabrainz/listenbrainz-server · GitHub
I made a few fixes for and embarked on a big refactor of the ListenCard component, which I finished today:
Refactor ListenCard component by MonkeyDo · Pull Request #1620 · metabrainz/listenbrainz-server · GitHub
I also fixed our javascript automated tests that were outputting a massive amount of logs and warnings, making the CI logs output basically unusable
And finally had an IRL chat with @rob and @alastairp about the structure of listens metadata

@alastairp

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@alastairp

last week I did some LB and CB reviews
I had a good discussion with @rob about what’s needed to finish my PR on renaming users in LB, that just needs one more change
I had a discussion about building a nuclear power station
and then a discussion about what to name fields in a listen json structure
one of them took longer than the other
finally, I spent some more time migrating AB js to typescript, fixing all of the eslint errors

@rob

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@rob

last week was a lot of work on the MBID mapping/album lookups and the like.
@mr_monkey and I worked on the new feedback page for LB where you can see the tracks you loved/hated, which means you can now play that page, which is really cool!
I’m on a bit of a bend right now to go improve music discovery workflow in LB – we’ve got some tools ready, but they are not well integrated yet.
so, aiming to fix that over the next few weeks, so we have some working methods for music discovery.
oh yeah, we also thought up something cool for the team for the summit.
is a tease

@akshaaatt

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@akshaaatt

This week I progressed my work on the mb interface.
I have so far gone from vanilla js < react basics < react hooks < remastering to components < using typescript < normal bootstrap < trying react bootstrap and react strap < trying other methods < making a global style < giving individual styles to components
Currently, the things seems fine
My work got a bit complicated this week because I was literally adjusting the same things to different formats again and again.
I am giving extra care to things rn because if I don’t follow the best solutions from the beginning, I might have to face the consequences of messing up the format later.
The good news is that the design from my end is final and I am waiting to have it come live before I ask for feedback.
I started making PRs yesterday and hopefully a lot incoming to expect from me this week.

@lucifer

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@lucifer

i worked on finishing up and testing the sir PR. it seems to work fine so far. it has been up on test.mb for some days. we do not have a good test suite for sir currently so it works. correctly or not is another question. do test out the search functionality on test and please report any issues you find.
other than that i worked on cleaning up the stats setup in LB backend and started work on adding sitewide stats

@Freso

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

Seems like I get to wrap this up.
Dealt with reports across the various sites, did some admin stuff on forums and the user report mailing list, and was generally around and about.

Invoices

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@rob

ok, here is what I want to try:
the first team meeting after the 3 day period for people to get their invoices in, I’ll add a meeting item, where the offenders get a chance to explain why they failed to submit the invoices.
you can get out of it, by submitting your invoice before the item comes up.
we’ll see how that works.

Dead link collection

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

So, we got a message from someone who works with wikidata data and was also looking at MB and then at stuff linked from MB
With many thousands of URLs linked to artists that seem dead
That does include ended rels (since they didn’t know about those) but a large majority are probably legit
I have no idea what to do with that info though (it’s a very very large file)
Any suggestions? I could just throw it on the forum and see if anyone does anything, but…

It was generally agreed upon to have a bot go through the list and mark relevant URLs as ended (if they’re not already). @reosarevok will draft up a spec for this and present in next meeting.