ROpdebee's userscripts support thread

MusicBrainz
63

As you have probably already noticed, we have merged a PR with the low hanging fruit improvements and the fix for the URL encoding issue:

For the remaining suggestions and bug reports I have created a few tickets, thanks for reporting:

4 Likes
64

So I’ve been debugging this issue with Violentmonkey Beta for a couple of hours now, turns out it’s not an issue with the cover art uploader itself. I’ll spare you most of the technical details (check the Github issue to know more) but it boils down to a conflict between ECAU and some other script (could be any installed script). There’s unfortunately no way to reliably fix this issue, but I’ll see what I can do. Even if I manage to fix it on my end, it’s still possible that you have some conflict-causing userscript installed which I don’t.

Edit: I fixed my scripts to prevent this. For me, Supercharged Cover Art Edits was causing the conflict, so that might do the trick for you too.

1 Like
65

What is ECAU?
For the record, I have just had a bug report on beta.
In my case, it’s not caused by ECAU, but by the newer version of React being used, there.

66

ECAU = Enhanced Cover Art Uploader.

The bug I was discussing above was about the Violentmonkey Beta, unrelated to MBS beta changes (but I’ll keep an eye out for any breakages due to the React upgrade on my scripts, so far all looks fine though).

2 Likes
67

Can confirm it was this.$ = jQuery stuff. Mostly affects scripts in the @murdos repo.
Notably Musicbrainz UI enhancements

And there is a just added packaging:

56: 'Clamshell Case',
1 Like
68

Enhanced Cover Art Uploads

  1. Some VGMdb entries have no cover art:
    https://vgmdb.net/album/111880 
instrument.js:102 [mb_enhanced_cover_art_uploads] Searching for images in VGMdb release…
instrument.js:102 [mb_enhanced_cover_art_uploads] Failed to grab images TypeError: Failed to construct 'URL': Invalid URL
    at MB： Enhanced Cover Art Uploads.user.js:107774:22
    at _await (MB： Enhanced Cover Art Uploads.user.js:106049:3739)
    at MB： Enhanced Cover Art Uploads.user.js:107767:18
(anonymous) @ instrument.js:102
onError @ MB： Enhanced Cover Art Uploads.user.js:106052
(anonymous) @ MB： Enhanced Cover Art Uploads.user.js:106052
fireHandlers @ MB： Enhanced Cover Art Uploads.user.js:106052
error @ MB： Enhanced Cover Art Uploads.user.js:106052
(anonymous) @ MB： Enhanced Cover Art Uploads.user.js:108518
Promise.then (async)
_catch @ MB： Enhanced Cover Art Uploads.user.js:106049
(anonymous) @ MB： Enhanced Cover Art Uploads.user.js:108513
_call @ MB： Enhanced Cover Art Uploads.user.js:106049
_processURL @ MB： Enhanced Cover Art Uploads.user.js:108510
(anonymous) @ MB： Enhanced Cover Art Uploads.user.js:108494
_finallyRethrows @ MB： Enhanced Cover Art Uploads.user.js:106049
(anonymous) @ MB： Enhanced Cover Art Uploads.user.js:108491
_call @ MB： Enhanced Cover Art Uploads.user.js:106049
processURL @ MB： Enhanced Cover Art Uploads.user.js:108490
syncProcessURL @ MB： Enhanced Cover Art Uploads.user.js:108605
(anonymous) @ MB： Enhanced Cover Art Uploads.user.js:108447
r @ helpers.js:71

Occasionally I’ve seen that error for other providers even though an image is there

  1. Cover art providers

Yandex Music (MBS-12441)

https://music.yandex.com/album/13554341
https://avatars.yandex.net/get-music-content/4382806/8af5be94.a.13554341-1/orig

VK Music (MBS-12439)

https://vk.com/music/album/-2000461927_10461927
https://sun9-86.userapi.com/c858436/v858436178/23326c/FPnyNc-lq6k.jpg

Limited to 1184px? Seen that resolution for other albums too

Trivia

Apple Music of all things has only a horrible upscale for that album:

https://music.apple.com/us/album/1549788134
https://a1.mzstatic.com/us/r1000/063/Music122/v4/81/50/08/8150083f-d7f1-8821-378f-405e04f2c3b0/0.jpg

Audiomack (MBS-12445)

https://audiomack.com/key-glock/song/pain-killers
https://assets.audiomack.com/key-glock/fbc4f33e8133ea04d0fc56abbdee067c117a78ab2f151708346e822d2a1e91aa.jpeg

https://audiomack.com/key-glock/album/yellow-tape-2-deluxe
https://assets.audiomack.com/key-glock/f879a0938375da775a061d710d7bc8d94e7909f52502fa3d00d5d6337c543b59.jpeg

Display CAA image dimensions

Currently trying out the preview version

  1. File info is now centered but this doesn’t fit well on e.g. remove cover art pages.

  2. When I first installed it no file info was shown. So I went and deleted localStorage and IndexedDB entries related to the script, afterwards it worked. Of course when I tried to reproduce it there were no problems.
    ¯\_(ツ)_/¯

  3. Script doesn’t run everywhere anymore. This looks intentional but some pages are missing like
    https://musicbrainz.org/user/<username>/edits/open or collections

Paste multiple external links at once

  1. Seems fully broken
helpers.js:88 Uncaught TypeError: Cannot read properties of undefined (reading 'child')
    at HTMLInputElement.handleLinkInput (MB： QoL： Paste multiple external links at once.user.js:75:52)
    at HTMLInputElement.r (helpers.js:71:23)
handleLinkInput @ MB： QoL： Paste multiple external links at once.user.js:75
r @ helpers.js:71
1 Like
69

I’m going to squash together some updates into one post.

In case anyone else wants to beta-test the new version of the CAA Dimensions script, follow the link in @chaban’s post above and feel free to report any bugs here or in the GitHub pull request. It’s pretty much been rewritten from scratch, so bugs are definitely possible, but we’ve tested it quite extensively so far and it seems to be quite stable at this point. We’ve definitely missed some edge cases though :slight_smile:

For those that don’t want to beta-test it: Don’t worry, it should release soon, and normally you’ll be auto-updated to the new version within a couple of days of that happening.

Caveat about automatic updates of the beta version

The beta version will not auto-update to new beta versions and your userscript add-on will probably complain that the script is 404 when checking for updates. That’s normal. Unfortunately you’ll have to manually reinstall if you want to catch up with the latest changes in the beta. The link will remain the same, but I might not always remember to actually synchronise it with the latest changes, so ping either me or @kellnerd to update the preview version if necessary.

The beta version will update to the stable version once it’s released.

In other news, you might have been spammed by a pesky update notification in the Enhanced Cover Art Uploads script that just didn’t want to go away yesterday. A hotfix should be out, apologies about that! Next time you’ll see it, it’ll say something useful, promised!

We’ve got changelogs now! :tada: Could be useful if you want a detailed digest of what’s been happening to the scripts. The most important stuff will be covered by the update notifications though.

Only works for Enhanced Cover Art Uploads at the moment, and soon also for CAA Dimensions. The other scripts will be added later.

Question for anyone that uses Enhanced Cover Art Uploads and also uploads homemade cover art scans: Do you use any file naming patterns for your scans? Like cover_front.jpg for front covers? I’ve been thinking of auto-filling types based on file names of uploaded files, either in ECAU or in a new script, so feel free to share your file name patterns!

Thanks for beta testing the new CAA Dimensions rewrite and for the continued bug reports @chaban! I’ll transfer the issues to the GitHub repo.

About the second issue: Can you clarify what you mean by “no file info was shown”?

  1. Nothing was shown at all (neither dimensions nor file size)? If so, is it possible that you had another tab open that was still running the old version of the script? Then it’s probably the bug described at the bottom of this comment.
  2. Dimensions were shown, but no file size?
  3. Dimensions were shown, but file size and type were something like undefined (NaN)? (This shouldn’t happen any longer, but was an issue in earlier previews.)
7 Likes
70

I suspect that was the reason. I installed the preview version while having some edit search tabs open. Refreshed only one tab and nothing was shown at all.

I don’t but others do

1 Like
71

I’ll often bulk upload after a scanning session. Nice idea. This would be especially useful when uploading a scanned booklet. If page 2-3.jpg got copied to the comment too it would save a lot of copy pasta work.

Mostly I use the same names, with slight variations like “front”, “CD”, “rear”, “matrix”, “page xx-yy”. Also “CD1”, “CD2” and “DVD1”, “DVD2”.

I don’t know about other people, but if anything with a number in it was copied to the comment field would be very useful. (24 page booklets can be a lot of copy\pasting). If I upload “page 08-09.jpg” and “page 08-09” was copied to the comment, that would be an amazing time saver on bigger booklets.

Oh - and a HUGE thank you for your handy tool. Big time saver when picking up art from elsewhere. Just copy \ pasting a URL has saved so much time. You are a star. :star: :star: :star:

3 Likes
72

An srrDB provider for Enhanced Cover Art Uploads might actually make sense… :thinking:

@IvanDobsky Yeah the idea would be to fill both types and comments. Probably with some presets for file naming patterns and some customisability so you can configure your own patterns. Not sure how that’d be achieved without requiring knowledge of regular expressions, but I might figure something out. Don’t hold your breath until it arrives though, it’ll be a while :slight_smile:

Should such a file name parser be included into Enhanced Cover Art Uploads (ECAU), or does it warrant a new userscript? It’d certainly enhance the uploader, but ECAU is already bulky (and will get bulkier in the future every time a new cover art provider is added). Poll time!

  • Put it into ECAU!
  • New script please!
  • Both options work for me
0 voters
1 Like
73

If you have it in a separate script I assume it would be easier to maintain. Especially if ECAU is becoming a many tentacled beast.

I’ll watch out for any test version as I upload a lot of artwork from my collection. A constant ongoing mission to scan everything and get CAA to back it up for me. :slight_smile:

2 Likes
74

The newest version of ECAU doesn’t set the first image to Front automatically like older versions did. @ROpdebee, is this intentional?

1 Like
75

No, that’s unintentional. I’m guessing it’s via the a-tisket seed links? In that case it’s a regression that slipped through the cracks. It should be fixed in latest version.

1 Like
76

Yes. I imported some cover art to releases that already had Amazon or Bandcamp links attached, and didn’t have the same problem.

1 Like
77

Enhanced Cover Art Uploads

I have come across a couple Apple Music releases where the original cover couldn’t be downloaded. The script falls back to the old method but still displays the filename of the original in the upload form. The edit note correctly includes 999999999x0w-999.png

Skipping maximised candidate https://a1.mzstatic.com/us/r1000/063/Music124/v4/77/98/bc/7798bc62-f1b2-0a15-6e98-2978a35b0e27/635212056714.jpg: HTTP error 502

Server Connection Closed
Description: The server closed the connection before the transaction was completed.

Looks like the releases in question are now working

Seed the batch recording comments script

  1. DJ-mix comment no longer includes release title: part of “” DJ‐mix
    Seems to affect Violentmonkey stable and beta alike.

Now here is a fun discovery:

  1. … which revealed that warnings are repeated on each click
  2. Can it handle “recorded at” event relationships yet? It seems not. Errors for existing comments and adds just live to the other ones:
Track #1.1: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.2: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.3: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.4: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.5: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.6: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.7: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.8: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.9: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.10: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.11: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.12: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.13: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.14: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.15: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.16: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
Track #1.17: Refusing to update comment: Significant differences between old and new comments: live, 2015-08-19: MTV Unplugged, The London Studios, London, UK vs live, 2015‐08‐19
  1. New “recorded during” event series relationship types:

Inline all recording’s tracks on releases

This one doesn’t reliably work for me. Even for the same release.

There is nothing in the console and API request goes through just fine. It was the only script enabled. Although when I enable some more it sometimes works. Apparently INLINE STUFF makes it work.

E.g. with this config it doesn’t work for me. But as soon as I enable INLINE STUFF it magically works.

Display CAA image dimensions
REVIVE DELETED EDITORS
MASS MERGE RECORDINGS
MERGE HELPOR 2
Compare AcoustIDs easier! (enableMiniIcons = false)
MASS ISRC
Change release quality
Mark recordings as video
Lean display
Seed the batch recording comments script
Inline all recording's tracks on releases
Set recording comments for a release

Once I also enable Blind Votes and Supercharged Cover Art Edits it stops working again. Plus I finally see an error:

instrument.js:102 Loading “Thrivemix Presents: Electro” shadow release…
instrument.js:102 Loading AcoustIDs…
helpers.js:88 Uncaught TypeError: recAnchors is not iterable
    at HTMLButtonElement.loadAndInsert (MB： QoL： Inline all recording＇s tracks on releases.user.js:95:20)
    at HTMLButtonElement.dispatch (MB： Supercharged Cover Art Edits.user.js:4435:9)
    at HTMLButtonElement.elemData.handle (MB： Supercharged Cover Art Edits.user.js:4121:28)
    at HTMLButtonElement.r (helpers.js:71:23)
helpers.js:88 Uncaught TypeError: recAnchors is not iterable
    at HTMLButtonElement.loadAndInsert (MB： QoL： Inline all recording＇s tracks on releases.user.js:95:20)
    at HTMLButtonElement.dispatch (MB： Supercharged Cover Art Edits.user.js:4435:9)
    at HTMLButtonElement.elemData.handle (MB： Supercharged Cover Art Edits.user.js:4121:28)
    at HTMLButtonElement.r (helpers.js:71:23)
DevTools failed to load source map: Could not load content for chrome-extension://opokoaglpekkimldnlggpoagmjegichg/moment-with-locales.min.js.map: System error: net::ERR_BLOCKED_BY_CLIENT

Blind Votes

  1. Suggestion: Don’t hide names of users whose edits/votes one is viewing. Edit search might be tricky
  2. There are layout shifts. Especially on individual edits the form controls are moving around. In edit listings it’s not that much but maybe there is a way to avoid them entirely.
Screenshots

musicbrainz.org_edit_90324088 (1)
musicbrainz.org_edit_90324088
Screenshot
Screenshot (1)

1 Like
78

I didn’t want to spam too many edits, therefore new post.

About prospective auto-filling based on filenames. Scans can be contained in multiple sub-directories. Wouldn’t it be even more awesome if one could recursively upload and fill the types, comments?
Example: 73e4b5ce49e89ef3f012b7da547235cae51123c5

Relevant files 
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Ads/01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Ads/02.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/02.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/03.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/04.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/05.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/06.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/07.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/08.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/09.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/10.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/11.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/12.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/13.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/14.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/15.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/16.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/17.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/18.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/19.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/20.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/21.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Booklet/22.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/02.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/03.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/04.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/05.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/06.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/07.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/08.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/09.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/10.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/11.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/12.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Box/13.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Case (CD1-2)/01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Case (CD1-2)/02.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Case (CD1-2)/Backcover/01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Case (CD1-2)/Backcover/02.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Case (CD1-2)/Cover+Sticker/01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Case (CD1-2)/Cover+Sticker/02.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Case (CD1-2)/Cover+Sticker/03.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Case (CD1-2)/Cover+Sticker/04.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Cover.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Disc/01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Disc/02.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Disc/03.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Sleeve (CD3)/01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Sleeve (CD3)/02.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Sticker/01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/BK/Sticker/02.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/Cover_01.jpg
[2021.06.30] 電音部 ベストアルバム -シーズン.0- [MP3 320K+BK]/Cover_02.jpg

Related ticket:

1 Like
79

I think it may be because doing that, you are delaying @ROpdebee script a little bit more, just enough time to make it run on a stabilised tracklist.

Since a recent change on the MB release tracklist display with React, the tracklist is not stable as soon as the page is loaded and many userscripts will work only if they are delayed.

It’s just a work-around until the scripts do actually support this server change properly.

1 Like
80

FYI: Today’s update to the CAA Image Dimensions script broke it, at least for me.

81

Uh oh… Which version of the script? Browser and userscript add-on?

Anyone else facing the same issue?

82

I was running the script through Tampermonkey on Chrome version 102.0.5005.61, but as soon as I updated Chrome and relaunched it went back to normal.