Notes from #MetaBrainz Meeting 2021-12-13

[Freso]

MetaBrainz Meeting 2021-12-13

Meeting start: IRC Logs for #metabrainz | MetaBrainz Chatlogs

Violin Monday

Vanessa-Mae - Storm (Official Video)

Agenda

• Reviews
• Gravatar (MD5 adresses)
• MB team ignoring telegram
• Upcoming meeting(s)

Last meeting: 2021-12-06
Next meeting: 2022-01-10

Reviews

@ApeKattQuest_MonkeyPython

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@ApeKattQuest_MonkeyPython

has been afk
( however see )

@reosarevok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

I worked on updating open PRs to the latest master and fixing eslint / Perl::Critic issues found by new rules
And also worked a ton on MBS-11312
Which is now working, but needs eyes of course
Plus some more admin tools

@rob

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@rob

last week was all about year in music and almost nothing else.
I’v got 4 playlists being generated and I’m putting on the finishing touches now.
I’ll start generating data tomorrow, with the goal of releasing them on wednesday as planned.

@alastairp

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@alastairp

last week I fixed a few quality of life bugs in LB (double log messages, files owned by root on linux)
I started to write a submitter for genres, but managed to delete it somehow redoing that now
had an interesting discussion with @rob about future of AB/how we can make it more useful. some things to think about there, more news in the new year we hope
on Friday I helped lucifer mitigate the log4j exploit in the MB search cluster
2 days of holiday in spain last week, so I took some time off too

@yvanzo

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yvanzo

Also helped with mitigating CVE-2021-44228 in MB Solr on production and for mirrors.
Reviewed some MBS PRs.
Jira server update is still going on.

@lucifer

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@lucifer

last week, i had did some work on YI stuff to add total listen counts/listen count per day and top stats.
helped in debugging some mapping edge cases (LEFT JOINs say hello), debugged listen counts issues (continues to be a pain)
also helped in optimizing top missing tracks query and in the process discovered an awesome website for pg explains https://explain.depesz.com/
towards the end of the week, the log4j RCE was disclosed. initially, we thought we were unaffected but in some time realised we run several Java based services. (SOLR, ES, Spark and JIRA). helped others with patching and investigating impact.

@bitmap

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@bitmap

last week I worked on some functions/triggers for the *_tag_raw tables to keep the tag.ref_count and aggregate count columns in sync
those are pretty much done. I’m writing the upgrade script to fix the existing counts today and then I’ll add some pgtap tests, hopefully.
fyi tag.ref_count is a count of how many times the tag is references at all, but the aggregrate counts on e.g. artist_tag.count is a sum of the votes (downvotes being negative)
other than that I worked a little bit more on React-ifying events/actions in the release editor

@mr_monkey

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@mr_monkey

The biggest chunk for me last week was continuing the year in music page, which is pretty close to finished now.
I also reviewed PRs on LB and BB, and continued finishing up some old PRs on LB
Helped new contributors with some local development issues, and helped them navigate the codebase, answered questions, etc.
In short, some new contributor onboarding
following the log4j report, I read some documentation for upgrading ElasticSearch. It’s not currently vulnerable, but BB is using an old unsupported version that needs updating

@akshaaatt

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@akshaaatt

Last week I resolved over a million Eslint issues in my MB PR which is good to be reviewed and finalized soon!
Also, I read a few posts on the community forum that mb isn’t showing up on Google searches, one reason being the mobile support and hence I’m pumped to get the revamp going on full throttle!
I connected with @aerozol a bit as he mtivated me to design even more mb pages!
I’m badically going to refactor a lot of code this month across projects this month!
Had some lb work going as well including year in music and cleanup stuff

@zas

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@zas

Last week, I upgraded discourse (it fails, I had to fix it quickly)
I also upgraded our grafana instances (security issue)
I worked on Picard upcoming release, mainly French translation (a lot of strings to translate)
plus usual stuff and help on LOG4J issue

@Freso

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

Editor we’ve been dealing with for the last few weeks popped up once, so spent some time looking for other activity from them.
Reviewed/feedbacked some PRs.
Dealt with some spam profiles on MB and forums.
Oh, and I helped @rob get the “mayhem” nick on this network.

Gravatar (MD5 adresses)

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@ApeKattQuest_MonkeyPython

recently @chaban pointed out on MBS-9725 that the MD5 email address hashes were cracked
and I agree with them that it is about hightime we really remove gravatar.
I also know that it hasn’t been done because a lot of other stuff needed doing anyway" (which is fine)
but now with this issue, maybe we should expedition the solution of MBS-9725 a bit?

It was agreed to move on with removing Gravatar even if Discourse avatar replacement wasn’t in place yet. @bitmap said they’d “submit a PR to remove gravatar today”.

MB team ignoring telegram

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@rob

so, it happened again today. last time we left it at “we’ll turn notifications back on”, but that clearly didn’t fix it.
bitmap: how can we improve this?
I think it might be time to setup time slices where certain team members are responsible for watching things/
everyone on the team should have a basic idea on how to do diagnostics.
and if someone doesn’t know how, but sees the alerts, then this person should rouse others to help.
but sitting by and doing nothing, simply isn’t acceptable anymore.
kinda stuck and paying attention to things is far far better than “not my problem”.
and not everything can be bitmap’s problem. that isn’t fair to bitmap.
so, I’m giving a concrete assignment to the [MusicBrainz team]
I want a plan for how this get improved. I want a plan to addresses who is responsible at a certain time of day and I want a cross training plan.
this is due for the first meeting in the new year, ok?

There was disagreement with the story as presented as well as the manner with which it was presented. @bitmap, @reosarevok, and @yvanzo all acknowledged the assignment.

Upcoming meeting(s)

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

Next Monday is a few days before Christmas, after that is between Christmas and New Year’s, and then after that is just after New Year’s. Any of these we want to cancel? (I assume the one on the 27th is off, we usually don’t do the Monday in between Christmas and NY.)
But do we want the 20th and/or the 3rd off as well?

Various team members are travelling or otherwise occupied at various intervals between December 20th and January 12th, so all of December 20th, December 27th, and January 3rd were called off, making the next meeting January 10th. Happy holidays!