Notes from #MetaBrainz Meeting 2021-08-02

[Freso]

MetaBrainz Meeting 2021-08-02

Meeting start: IRC Logs for #metabrainz | MetaBrainz Chatlogs

World Breastfeeding Week Monday

Rainbow Children's Hospital & BirthRight's breastfeeding song | English | World Breastfeeding Week

Agenda

• Reviews
• Personal data in edit history
• Amazon cover art

Reviews

@yyoung

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yyoung

• I rebased my PR #2114 on PR #2151, refactored ExternalLinksEditor a little bit, fixed tests and bugs.
• Continued to implement MBS-9902, added a feature to limit possible type options and support of custom auto-select function.
• Looked into backend code related to MBS-3774.
• (Also regular editing on MB, more and more questions and confusion are coming up…
• That’s all, thank you.

@mr_monkey

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@mr_monkey

Last week I worked with @akashgp09 on some details of the GSoC project
And also worked on more improvements to the ListenBrainz player
And that’s about me for last week! I’ll be mostly off comms in August but can be reached if need be !

@lucifer

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@lucifer

i worked on migrating spark jobs to use new style parquet dumps and spent lot of time looking into rabbitmq nuances we have been seeing in LB.
i also did some work on acessing CB database directly from LB for jasondk 's project. the approach didn’t pan out. i’ll start work on a different approach (access using CB oauth) this week.
i also did some PR reviews for @akshaaatt

@rob

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@rob

vacation

@yvanzo

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yvanzo

Last week, I kept working on search indexer mostly.
Read the comments to @yyoung’s project and continued helping him with the next steps.
Last, made progress towards running Selenium tests with MB Docker development setup.

@zas

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@zas

Last week, I did usual server maintenance, blocked user support, upgrades, and supervision
also worked on Picard, mainly code reviews, tests & feedback
we finalized the move from williams to aretha
and got a new server today (in place of williams): patton
it is now up & running

@bitmap

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@bitmap

last week I worked more on porting the release relationship editor code from knockout, working on the batch-editing tools (creating works) and data submission
fighting a lot with “state management” code right now…
we also had some MB team meetings to discuss PRs and whatnot

@reosarevok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

Last week I worked on a few smaller PRs, and I started trying to make sense of the guess case code to update it to the 21st century
Still ongoing, as anyone who saw the previous convo in this here our channel will know
I also worked on MBS-9426 / MBS-11828 for @Freso today
But really, I can use those too for support uses, so I’m being selfish here
I also started trying to organize my working day a bit more by actually setting up in advance what to work on in my Notion journal/calendar/thingy
So far it seems practical
This week I have a bunch of small tickets preselected, plus more of the guess case mess

@ApeKattQuest_MonkeyPython

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@ApeKattQuest_MonkeyPython

Yea, I doth edited the bookbrainz database and surveyed many tickets.

@akshaaatt

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@akshaaatt

This week we did the release as @lucifer mentioned
I even had a blog out on the blogs.meb page
https://play.google.com/store/apps/details?id=org.metabrainz.android Update please everyone!
MusicBrainz App – MetaBrainz Blog
Thanks to @lucifer for the constant support!
Other than that I’m really really studying a lot of DSA and solving problems. Quite exhausted!
Will work on finalizing my GSoC project in the upcoming weeks!

@Freso

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

I poked at some more ListenBrainz spammers and have cleared out a couple more accounts.
Dealt with some reported editors and some forums flags.
Oh, resumed meeting notes for these meetings too.
Notes from #MetaBrainz Meeting 2021-07-26
Tried to be a bit more actively/visibly around and about too.

@alastairp

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@alastairp

last week I attended a conference, presenting some work that I had done at UPF: Notes on the Music | Proceedings of the 8th International Conference on Digital Libraries for Musicology, so as a result I wasn’t around too much
I did some code review for LB that went towards last week’s release
I spent some time writing a blog post for AB’s acoustic similarity, but that’s not finished yet. planning to get that out this week
I converted AB’s javascript code to TS
I worked with @lucifer on a few backend tasks in pythonbrainzes
I’ll be around FT for the first 2 weeks of august, and then away for 3 weeks.

@jdaok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@jdaok

last week I did some refactoring of some old code
Refactor load recording from UUID functions by jdaok · Pull Request #1570 · metabrainz/listenbrainz-server · GitHub
and I began creating the frontend review modal component on the CB x LB integration project I’m working on with lucifer.
I’ll continue to flesh that out this week.
I also went apartment hunting since schools starting up again in a bit :3

@ritiek

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@ritiek

last week i worked on getting level relationship includes support in musicbrainz_rs
i also added search support on a few entities
and improved our library docs

@akashgp09

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@akashgp09

Last week I worked on reverting some of the changes of relationship Editor
Revert relationship editor changes by akashgp09 · Pull Request #679 · metabrainz/bookbrainz-site · GitHub
Created a new series editor component for adding series items and setting the attribute’s value for the item
feat(series): separate editor for adding series items by akashgp09 · Pull Request #680 · metabrainz/bookbrainz-site · GitHub

Personal data in edit history

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

So: we discussed this a bit last week without @rob but I wanted his input
We already remove birth dates from the database on request, because we consider them personal data
But that leaves them in the edit note history (which is fairly public nowadays)
I was asked on support a bit over a week ago about removing them from edit data, and it seems sensible if we’re going to redact them
I got some suggestions about ideally storing these dates as effectively [REDACTED]
Since we don’t want to remove the edit, just hide the data

Rob gave his +1 to this approach. A tiny bit of implementation detail discussion happened.

Amazon cover art

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@bitmap

so this is re MBS-11082 - since sometime last year, the API we use to fetch amazon artwork changed
we could fix it, I think, though it’s a lot more complicated with having to sign requests and all
do we want to bother keeping this now that that CAA is well established?

@Rob asked if we “have a feel for how often we have things in CAA vs amazon?”

@reosarevok posted this from the statistics:

Releases:	2,943,430 	
CAA:	1,425,282 	48.4%
Amazon:	137,988 	4.7%
URL Relationships:	108 	0.0%
No front cover art:	1,380,052 	46.9%

With those numbers presented, it was agreed to drop the Amazon cover art functionality entirely.

[aerozol]

Thanks @Freso, seeing these is always awesome, makes you realize how much is going on