Notes from #MetaBrainz Meeting 2021-07-26

[Freso]

MetaBrainz Meeting 2021-07-26

Meeting start: IRC Logs for #metabrainz | MetaBrainz Chatlogs

Esperantotago

Tiel la Mondo Iras (Song in Esperanto) by Juliano Hernández Angulo

Agenda

• Reviews
• Personal data in edit history
• MBBE_Bot autoedits

Reviews

@yyoung

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yyoung

• I made the last changes to PR #2151 and communicated with editors on the forum.
• Experimented a way to implement MBS-9902 and opened a PR for review.
• Made a UI prototype for MBS-3774 according to @reosarevok’s suggestion and posted it on the forum for feedback.
• That’s all, thank you.

@mr_monkey

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@mr_monkey

Hi everyone!

Last week I mostly worked on some improvements for the ListenBrainz player. Some stability improvements and the addition of new features, namely native notifications and media control. Associated PRs are #1539 and #1561 which have more detailed descriptions.
You can test this all out on test.listenbrainz.org, and feedback would be very appreciated if you find anything that looks broken or unintended (or if you’re happily surprised too).

Apart from that I also reviewed some BookBrainz PRs.

That was it for my week! Take care y’all !

@rob

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@rob

slow week for me, just some bits and bobs, was on semi vacation am on vacation now.

@lucifer

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@lucifer

i worked on migrating spark jobs to use new style parquet dumps and spent lot of time looking into rabbitmq nuances we have been seeing in LB.
i also did some work on acessing CB database directly from LB for jasondk 's project. the approach didn’t pan out. i’ll start work on a different approach (access using CB oauth) this week.
i also did some PR reviews for @akshaaatt

@alastairp

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@alastairp

last week I finished and merged Aidan’s work on acoustic similarity on acousticbrainz
this involved lots of small things related to database migrations, fixing some rarely used helper scripts, and improving data display on the web
today I also did some work on improving the time needed to generate indexes, and fixed a bug regarding valid CPU extensions that we can use when compiling/running the similarity
that being said, I’m about to release on prod now (was on beta last week), and will write some blog/twttier about it
also did had some discussions with @lucifer about the CB stuff he was talking about, and some light PR reviews

@yvanzo

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yvanzo

Last week I mainly debugged search indexer and identified a new issue with indexing some MB recordings since last schema change.
That could explain the recent repeated crashes.
Also helped a bit with aretha migration but could not really achieve more than that otherwise.

@bitmap

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@bitmap

last week I worked on more tiny issues/annoyances in the React relationship editor, and worked more on the release verion (which is a bit more complicated since it edits recordings/works too).
was hoping to submit that last week but I still need to finish edit submission there, since it submits edits asynchronously/piecemeal unlike the standard entity forms.
I also helped move containers to the new aretha server – postgres-williams, the fullexport sshd container, etc.
and did a bit of code review but mostly on yyoung’s PR. doing more this week for the beta release

@reosarevok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

I worked on a bunch of small issues, some ISEs and whatnot, plus improving statistics a bit
I also spent a lot of time releasing the server last Monday evening, since I found two beta bugs we had missed (one minor, the second more serious) and had to restart twice
And I worked a bit with @Freso to try and help him with dealing with the old backlog so that he has less on his shoulders

@Freso

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

I had a meeting with Rob, reo, and Paul (from MeB board) about my position. As a result, I have stepped down as Secretary for the board and worked with reo to help me schedule and prioritise my work, which will hopefully lead to me actually being able to do things without burning myself out again.
Of actual thing-things, I have dealt with a bit of ListenBrainz spam and purged a couple of spammy users. Also opened LB-922 related to this.

@zas

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@zas

I did usual supervision, upgrades, user support
migration from williams to aretha is now finished, williams will be retired and replaced by a new server within next days
thanks to all on this
Picard PRs code review & merging, thanks to very active contributors (kudos to rdswift)

@jdaok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@jdaok

Last week I got some PR’s in for adding pinned recordings to the LB user feed,
and I worked on the implementing pin history tab page, which should be done this week.
I also began refactoring some code that would allow these pins to be playable with Brainzplayer.
this week i’ll start work on the CBxLB integration project’s frontend review modal component.

@ritiek

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@ritiek

last week i checked if our deserializer in musicbrainz_rs has been missing any fields compared to what gets exposed in the API response
i also worked on adding support for level relationship includes in musicbrainz_rs
also got the PR adding support for all regular relationship includes merged last week

@akshaaatt

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@akshaaatt

I’ve recently published my GSoC experience article at
https://medium.com/@akshaaatt/gsoc21-the-beauty-of-open-source-26369e04fbb9
Do give it a read!
Other than this I made some contributions to the mb app as well and we are excited for the release!
Campus placements have begun at my college and hence I’ve been studying a lot these days!

@akashgp09

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@akashgp09

Last week I worked on adding achievements for series creation:
feat: add achievement for series creation by akashgp09 · Pull Request #677 · metabrainz/bookbrainz-site · GitHub
Also, added the corresponding tests for it
test: add tests for series creator achievements by akashgp09 · Pull Request #678 · metabrainz/bookbrainz-site · GitHub
Debugged and fixed the issue of achievement endpoint.

Personal data in edit history

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

We have had several cases where users ask us to remove their personal data (birthdates, mostly)
We often do, but that only removes it from the actual data
There’s no mechanism to remove it from edit history, which I’ve been asked about because, well, edit history is now visible without login anyway, so it’s not very private at all
I understand that this should probably wait for a meeting with ruaok, but maybe we can leave it in the agenda and think about whether we have any ideas about how to deal with it for next week?

There was some discussion about how to go about this and some technical requirements. E.g., the data should be removed from the database, not just hidden in our own UI. There seemed to be consensus about keeping the edits, but replacing the removed data with something like “(removed)” greyed out.

Topic will be revisited again next week, when @Rob is around for the meeting.

MBBE_Bot autoedits

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

I was confused about why I wasn’t able to enter MBBE_Bot lyricwiki removals as autoedits (they get approved anyway immediately after I enter them by @chaban or @kellnerd)
Then I realized it’s because I never made MBBE_Bot an autoeditor
Would anyone strongly oppose making MBBE_Bot an autoeditor for those kinds of edits so we don’t flood people’s open edit lists?

Some discussion followed, where it was concluded that there was clear precedent for giving bots of autoeditors autoeditor status, so an official MusicBrainz bot should be good to go based on this. There was also some discussion about when it’d be okay to have MBBE_Bot do edits as autoedits. Generally the bot will be run for a couple of days on any given edit algorithm before being escalated to autoedits, and the decisions for what the bot does go through the MetaBrainz ticket system, which seems to be more scrutiny than most bots receive as well.