Notes from #MetaBrainz Meeting 2017-12-11

[Freso]

MetaBrainz Meeting 2017-12-11

Meeting start: Making sure you're not a bot!

Agenda

• Reviews
• Consolidated contributing guidelines video

Reviews

@ApeKattQuest_MonkeyPython

Making sure you're not a bot!

@ApeKattQuest_MonkeyPython

more students have done instrument tasks!
so far they’ve also done rather good work on their research!
this has kept me occupied with also adding instruments!
on Saturday was my birthday! yaay!
I’ve also found time to add some releases (notes booklets with attached cd’s)
and still working on the rock furore mess.
trying to keep up with kids and their enthusiasm!
also today I was away picking up my wretched computer, all fixed. yay!

@chhavi

Making sure you're not a bot!

@chhavi

This week I mostly worked with LordSputnik and Leftmost to do mockups for BookBrainz
We made quite a progress
That’s it. Will update later once we have more detailed mockups.

@samj1912

Making sure you're not a bot!

@samj1912

this week I spent a lot of time on sir live indexing
which culminated in a problem for our postgres master
so we are thinking of scrapping the current live indexing method
we will be brainstorming this week on how to deal with it live indexing
I also did gci mentoring

@Rob

Making sure you're not a bot!

@Rob

last week wasn’t too productive, traveling home and all.
I banged my head at deploying the metabrainz site, answered a few emails.
did a few PRs.
not terribly much, this week I’m jumping back in. I already got the MeB site updated and tweeted about the 2015 report.
LB is my goal for this week to get a beta version running… and to help samj1912 figure out how to make the index updater work.

@iliekcomputers

Making sure you're not a bot!

@iliekcomputers

Been busy with irl stuff this week, a few LB PRs and some code review. Nothing much else. Should be back in a few days.
That’s it for me.

@Freso

Making sure you're not a bot!

@Freso

I’ve been mostly sick this week.
Trying to keep up with GCI and IRC and such, but haven’t been as much around as I wanted.
Crazy week ahead of me too.

@Leftmost_Cat

Making sure you're not a bot!

@Leftmost_Cat

I’ve been working with chhavi_, who has put together some great wireframes for BB. Things are progressing quite well there.
I’ve also done some prelim work on dockerizing, which is going slowly because I have no idea what I’m doing, but it’ll get there.

@reosarevok

Making sure you're not a bot!

@reosarevok

Support, GCI
and I opened two international style discussions, Spanish band names and capitalization [STYLE-879] and Portuguese word capitalization inside parentheses [STYLE-881]
(input wanted if you speak Spanish and Portuguese respectively)

@bitmap

Making sure you're not a bot!

@bitmap

I spent some time reviewing sir/solr stuff and helped with deploying things
submitted a bunch of PRs for converting things to React and improving Flow types
started cherry-picking changes from my alternative tracklists branch so I can get that in in smaller chunks; mostly related to Flow types it needs
submitted a PR for metabrainz.org to improve the consul-template usage
helped tame bowie yesterday, which was fully resolved after we did a VACUUM ANALYZE; so I think the problem was possibly due to the hot_standby_feedback option being enabled, in combination with heavy activity from sir
after than spent time reading about pgpool-II which is something we must switch to eventually in order to have a sane PG cluster that supports failover (which right now is impossible for us with our current docker setup)
(@Rob: is this another reason for us to get a move on to kubernetes?)
it doesn’t depend on kubernetes but that might be a good time to switch it over
(@Rob: is pgpool a replacement for pgbouncer or yet another thing?)
it replaces pgbouncer, it has connection pooling builtin, but also does many other things pgbouncer doesn’t
like handling repliction, automatic failover, online recovery, etc.
it’s much more complicated than pgbouncer though, and can have a high write performance overhead, something like 10-30%
I guess we’ll have to investigate it more

@zas

Making sure you're not a bot!

@zas

first part of the week was about fighting myself (or my stupid body)… i feel better now
i upgraded many stuff: grafana, influxdb, nagios, and almost all servers
we have issues with size of docker logs, please, as dev, try to keep your logs not too verbose
i’m thinking about a solution, i’ll tell more about it when i’ll finished to evaluate the possibilities
i helped with few server issues: bowie pg master overload, and yehudi freeze yesterday
i reviewed/merged a bunch of Picard related PRs (plugins/website/picard)

@yvanzo

Making sure you're not a bot!

@yvanzo

I mostly reviewed JS updates (Lodash, React) and migration to React
fixed two small issues; continued the spam thing (delaying beta by one more week)
looked into bowie overload issue

@anshuman73

Making sure you're not a bot!

@anshuman73

this week I mostly looked into GCI and handling my exams with it
CB finally got some activity going on GCI wise which makes me happy, and we’re picking up the pace
hopefully we’ll try and finish out all the small tickets this GCI
next week should be more productive with my exams over

@naiveaiguy

Making sure you're not a bot!

@naiveaiguy

upgraded the Cb editor to SimpleMDE, and got it merged, which is my first significant contribution to open source!
also came up with the idea of language detection and implemented it
thanks to excellent advice from anshuman73
anshuman73 is trying to test that rn
i’m going to be working on many non-coding tasks this week
also experimenting with the SQL charts thing
all in all committed to making this week a huge success and being more productive

Consolidated contributing guidelines video

Making sure you're not a bot!

@naiveaiguy

due to the high number of new contributors coming thanks to GCI
I was thinking that we should consolidate all our contributing information into one big video/document
right now, the spread out information may be confusing to newcomers
made a gist with what I think should be included:
https://gist.github.com/eshansingh/c558c0640dfbd7801cae76872f0c4214

@Freso pointed out How to Contribute - MusicBrainz (and that it needs updating), @iliekcomputers noted that all GitHub/code projects have a contributing.md file.

@samj1912 noted that he «[does]n’t think think [he] would watch a video about that» but would read a wiki page and also pointed to https://whatcanidoformozilla.org/ as a possible way of achieving something like this. @chhavi showed that there’s also What can I do for Fedora? - @samj1912 suggests using http://whatcanidofor.metabrainz.org/

There was some talk of doing it as a GCI task, or as a series of GCI tasks, but it would depend on one or more mentors picking it up and formulating tasks for it.

In summary:

@Freso

We’d love such a document, and we’d love for someone to try and make it.
A site like that would also be good.
We may or may not be able to put making such documentation/site into GCI tasks.

[dns_server]

@samj1912
For indexing you probably want to create a table in the database containing the id’s of items that need to be added to the search index.
You can then add a trigger for each table in the database that will fire on insert or update and have this trigger insert a record to this queue table.

The indexer tool just needs to have a loop that select one or a small number of id’s from this queue table, add the items to the index and deletes the id’s once done.

When building your first index you can run an insert into queue_table as select query to add everything to the queue.

[samj1912]

Yup, that’s what we were doing. There was a slightly different problem although it’s fixed now. It should be there in the minutes from later meetings.