Limited editors can edit instruments?


#1

As far as I can see https://musicbrainz.org/edit/48071031 should not have been possible.
Interestingly there is also no way to remove that relationship.


#2

Likewise: https://musicbrainz.org/edit/44588721


#3

a few more


#4

They can’t edit instruments, but any editor can add artist-instrument relationships, because they can add artist relationships.


#5

Odd, it’s showing on https://musicbrainz.org/artist/d74227f7-e3eb-4967-a4f5-db383e383992/relationships but not on https://musicbrainz.org/artist/d74227f7-e3eb-4967-a4f5-db383e383992/edit … so it doesn’t appear any editor can remove it.

edit: same problem at https://musicbrainz.org/artist/30bfa225-f1ef-4b06-a055-a4ea0ad209ba/edit — so it seems that the editor is failing to display artist-instrument relationships :frowning:


#6

So, no one can remove these relationships? Not even instrument editors?


#7

I can! Sorry, was summiting and forgot submitting.


#8

Huh.

So, the Edit-person tab doesn’t show the “invented” relationship for me because I don’t have access to edit/remove that relationship?

But it does show it for you?

So the bug here is that regular users have access to create “invented” relationships, and not that regular users can’t delete/edit them?


#9

Or, to rephrase the question:

Is this “regular users can create Artist-Instrument relationships but not delete them” situation the way you want things to be? Or is it just an unfortunate consequence of the current schema or other technical constraints? Or a bug/mistake that may be relatively easy to fix?


#10

Once again, someone else is more eloquent than me. :grin:


#11

It can only be removed from the instrument side, which you don’t have rights to edit. But by a subproduct of our edit system, this is possible to add from the other side, which everyone can edit. Not sure what a good fix would be without making it impossible for people to also add a future “X mostly plays violin” relationship though, which we do want to add.


#12

Well, we’d want people to be able to edit that “X mostly plays violin” relationship too—so if those two work the same way, somehow that needs to get fixed.


#13

No - the reason this specific relationship can’t be edited is because of cardinality (the same that makes, say, most artist-recording rels not to show in the artist edit page, because there’d be too many to use properly). That said, I think it’s probably fine to change the cardinality for this, because one artist usually doesn’t invent enough instruments to make this a problem, and obviously it doesn’t help avoid people adding this relationship anyway so we might as well make removing it easier…


#14

I made sure with @CatQuest since he’s the instrument don, and then changed this so it’s editable by anyone on the artist side. Can someone who is not an instrument editor like we are make sure it worked? :slight_smile:


#15

The two in this thread have already been removed (your edits were approved), so I went and looked for some more:

https://musicbrainz.org/label/b2b029a3-edf2-485b-84a6-bc2139c79202/relationships doesn’t show it on the edit tab, but that’s a label not artist (so maybe it needs fixing there too)

I couldn’t find another artist invented instrument already present, so I went ahead and added https://musicbrainz.org/artist/9b182733-e7ac-4ce6-86b1-eae2a54bed5f/relationships — that one appears to work for me. (Edit, later found https://musicbrainz.org/artist/31663409-4f26-4c65-bc2f-7bb738667dcc/edit which works for me too)

So seems you fixed artist-instrument inventor, but need to fix label-instrument inventor.


#16

Whoops, I completely forgot this existed! Fixed