Disc IDs from Hybrid SACDs

chaban · July 15, 2019, 12:30am

Just confirmed this. Release not yet in DB. ~~Will add it later.~~ Done
TOC

Deleted_Editor_1801019 · July 15, 2019, 7:59am

Hi there, yes, I used foobar2000 (1.5 b2) + foo_musicbrainz (0.3.9) + foo_input_sacd (1.1.3-2).
Sorry for the mess, I’m just feeling my way into all the possibilities of editing a release.

Edit: If there is a problem with calculating the hash, I could open a bug report on the SACD plugin author’s sourceforge page. I’d need some detailed info, though.

Deleted_Editor_1409249 · July 16, 2019, 12:42pm

I should be able to prevent foo_musicbrainz from making these erroneous submissions. I’ll let you guys know when I’ve done it.

outsidecontext · July 16, 2019, 1:34pm

@marc2k3 What component is actually responsible for calculating the disc ID here? Is it foobar2000 itself, foo_musicbrainz, foo_input_sacd or something else? Could whatever does the calculation be changed to make use of actual libdiscid?

Deleted_Editor_1409249 · July 16, 2019, 1:53pm

foo_musicbrainz does the DiscID calculation.

But I’m not even touching the code that does that. I’m just updating the code that won’t even let you open the menu option unless all tracks meet certain criteria. For example, this selection of tracks is OK…

and this selection is not…

jesus2099 · July 16, 2019, 2:07pm

But probably based on (in the case of @Jorgosch, erroneous) data provided by foo_input_sacd?

Deleted_Editor_1409249 · July 16, 2019, 2:21pm

Well it’s just the exponentially larger number of samples per track that is the problem. They’re far too large to be from a normal audio CD rip.

Deleted_Editor_1409249 · July 16, 2019, 2:37pm

Here’s an updated version which ensures the sample rate of all selected tracks is 44100 Hz for TOC submissions.

edit: there were already checks in place to make sure that samples % 588 == 0.

outsidecontext · July 16, 2019, 3:14pm

Ok, now I get it. So the disc ID calculation is not actually done by directly reading the CD TOC, but by relying on the metadata foobar is passing along with the tracks for playback, right? I guess this could lead to other wrong calculations. E.g. there might be no info on the pregap. Is this taken care of?

Deleted_Editor_1409249 · July 16, 2019, 3:40pm

I didn’t write the code but you can poke around at it here…

github.com

marc2k3/foo_musicbrainz/blob/master/foo_musicbrainz/TOC.cpp

#include <regex>
#include "foo_musicbrainz.h"
#include "TOC.h"
#include "Track.h"
#include "sha1.h"

using namespace foo_musicbrainz;

TOC::TOC(metadb_handle_list_cref p_data) {
	num_tracks = p_data.get_count();
	pregap = 150;
	discid = nullptr;
	tracks[0] = INT_MAX;
	cur_track = 0;
	tracks_lengths = new unsigned int [num_tracks];
	__int64 samples;
	t_size spf = p_data.get_item(0)->get_info_ref()->info().info_get_int("samplerate") == 48000 ? 640 : 588;

	for (t_size i = 0; i < num_tracks; i++) {
		samples = p_data.get_item(i)->get_info_ref()->info().info_get_length_samples();

This file has been truncated. show original

jesus2099 · July 16, 2019, 10:10pm

IMO we could remove the Add Disc ID to MusicBrainz feature completely from foo_musicbrainz.
It’s always better to submit from Picard which uses the official lib.

Deleted_Editor_1409249 · July 17, 2019, 11:59am

I have lots of reasons why I’m not doing that.

The original developer released the component over 10 years ago and most people will be using that as it’s still available for download.
Most people are lazy and use it to fetch tags only.
Hardly anyone will be aware that I’m updating it.
It correctly reads the PREGAP when you add a CD to a playlist like this…

It correctly reads the PREGAP when you use a CUESHEET generated by EAC like this…

It correctly generates the TOC for most CDs in my collection that are ripped to single files.

Yes there are instances where it won’t account for non-standard PREGAPs but if you look at this example…

That is not caused by foo_musicbrainz!!

Freso · July 18, 2019, 10:12am

I think a better solution would be for foo_musicbrainz to use libdiscid rather than to remove its feature altogether. We want it to be easier for people to add data (incl. Disc IDs) to MusicBrainz, not harder—but we also want them to submit correct data. So either any bugs in foo_musicbrainz should be fixed (it’s good to have multiple implementations of a standard!) or they should switch to use libdiscid for Disc ID calculation (it’s the official and canonical implementation and it’s good to support the upstream of that!).

Either way, as long as the lineage is observed via edit notes or some such, I’m fine with any outcome, as we can go back and determine “bad clients” later. Only issue with that is that it’s most often not given in edit notes what was used to calculate the Disc ID.

jesus2099 · July 18, 2019, 2:53pm

It would be nice that Add ISRCs edits could include Client parameter, like Add ISRCs edits do.

Freso · July 18, 2019, 3:29pm

The reason why it can’t is that Disc ID adds can’t be done via the web service. You can only add a Disc ID by looking up a Disc ID and the editor then has to go from there to either add a new release or add the ID to an existing release. Any data submitted from the client generating the ID will have been long lost during this process before you actually get to the edit. Maybe there are ways of passing an URL parameter or something around until the edit, but it seems a bit hackish. But maybe. @Bitmap/@yvanzo/@reosarevok?

jesus2099 · July 18, 2019, 7:08pm

Oh yes you’re right!
I didn’t think of that.

Zastai · July 19, 2019, 4:17pm

I will just add that I really really don’t want anything to generate disc IDs based on anything other than a real TOC. They are supposed to be a source of truth.

Hawke · July 19, 2019, 5:15pm

I generally agree, but I’m OK with a few other generally-good sources too: ripper logs (such as EAC or whipper) and cue files come to mind.

I’d also love to see the TOC idea extended to DVD title/chaptering patterns…

Deleted_Editor_1801019 · February 29, 2020, 10:59am

It looks like mark2k3 has deleted his github repository along with the foobar2000 component, so I guess that’s that.

outsidecontext · February 29, 2020, 11:30am

The development of foo_musicbrainz2 os being continued by @MordredKLB, see

Other code by marc actually seems to be lost, though