Bug when merging releases

Since today everytime I try to merge 2 releases I get the following error code:

TypeError: Cannot read properties of undefined (reading 'field')
    at /home/musicbrainz/musicbrainz-server/root/static/build/server.js:1:577528
    at Array.map (<anonymous>)
    at /home/musicbrainz/musicbrainz-server/root/static/build/server.js:1:577496
    at Fb (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server-legacy.node.production.min.js:65:44)
    at Ib (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server-legacy.node.production.min.js:67:254)
    at W (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server-legacy.node.production.min.js:73:89)
    at Jb (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server-legacy.node.production.min.js:76:98)
    at Ib (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server-legacy.node.production.min.js:68:145)
    at W (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server-legacy.node.production.min.js:73:89)
    at Jb (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server-legacy.node.production.min.js:76:98)

To enter the merge I have to go back from the error page and click enter edit again and it works; is anyone else facing the same issue?

4 Likes

Just had the same issue. Exact same screen. Obviously they are upgrading or something because the main site is now the beta site. So, hopefully all this will be back to normal soon.

Update: I guess it had nothing to do with being on the beta. Main site is back up. But still can’t merge.

2 Likes

At least I’m glad that it’s not just me having this issue. It was even reported twice on Metabrainz Tickets:

…the latter of which was entered by me.

4 Likes

In MBS-13729, @Fabe56 discovered that this can occur with the mb. MERGE HELPOR 2 script enabled.

I’m looking into what changed on the server to break the script (as there haven’t been any recent changes to the script).

Edit: This will be addressed by MBS-13729: `TypeError` while trying to merge releases by mwiencek · Pull Request #3357 · metabrainz/musicbrainz-server · GitHub.

5 Likes

Thanks! That was the issue. It’s the script.

2 Likes

Sorry, I was not aware, yet, that my clumsy script was causing issues!

@Bitmap, I don’t really know the problem. Is there anything I should fix in my script to stop crashing MBS?

1 Like

Well, it just started 2 days ago.

1 Like

It is now fixed on my side!

https://github.com/jesus2099/konami-command/issues/843#issuecomment-2307070162

Somewhere, I was replacing some MBS text node.
And this was curiously recently causing React-hydrate to remove the unrelated merge strategy <select> element.

To avoid that, I now insert stuff, not replace.
And now, there is no problems! :slight_smile:

5 Likes