Borked Edit Histories

IvanDobsky · October 20, 2020, 10:12am

I’ve been trying to work out why this page fails on me:
https://musicbrainz.org/release/9ac68a8c-0617-38a2-a5dd-a937046a38f6/edits?page=2

It is common and I get an error like this:

# Internal Server Error

**Oops, something went wrong!**

**Error:**

Couldn't render template "undef error - TypeError: Cannot read property 'linkTypeID' of undefined at a.createElement.a.createElement.a.createElement.a.createElement.a.createElement.l.map (/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js:1:786608) at Array.map () at t.default (/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js:1:786565) at d (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:36:498) at $a (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:39:16) at a.b.render (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:44:476) at a.b.read (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:44:18) at Object.renderToString (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:54:364) at getResponse (/home/musicbrainz/musicbrainz-server/root/server/response.js:102:31) at Socket.receiveData (/home/musicbrainz/musicbrainz-server/root/server/createServer.js:83:31) at lib/MusicBrainz/Server/Plugin/React.pm line 18. "

**Stack trace:**

* `line`
* `line`

**Edits loaded for the page:**

* [50282380](https://musicbrainz.org/edit/50282380) ([raw edit data](https://musicbrainz.org/edit/50282380/data)); fully loaded
* [50282377](https://musicbrainz.org/edit/50282377) ([raw edit data](https://musicbrainz.org/edit/50282377/data)); fully loaded
* [44622802](https://musicbrainz.org/edit/44622802) ([raw edit data](https://musicbrainz.org/edit/44622802/data)); fully loaded
* [44622801](https://musicbrainz.org/edit/44622801) ([raw edit data](https://musicbrainz.org/edit/44622801/data)); fully loaded
* [40032005](https://musicbrainz.org/edit/40032005) ([raw edit data](https://musicbrainz.org/edit/40032005/data)); fully loaded
* [40032004](https://musicbrainz.org/edit/40032004) ([raw edit data](https://musicbrainz.org/edit/40032004/data)); fully loaded
* [39618643](https://musicbrainz.org/edit/39618643) ([raw edit data](https://musicbrainz.org/edit/39618643/data)); fully loaded
* [37832781](https://musicbrainz.org/edit/37832781) ([raw edit data](https://musicbrainz.org/edit/37832781/data)); fully loaded
* [37832705](https://musicbrainz.org/edit/37832705) ([raw edit data](https://musicbrainz.org/edit/37832705/data)); fully loaded
* [35807504](https://musicbrainz.org/edit/35807504) ([raw edit data](https://musicbrainz.org/edit/35807504/data)); fully loaded
* [35645839](https://musicbrainz.org/edit/35645839) ([raw edit data](https://musicbrainz.org/edit/35645839/data)); fully loaded
* [33279425](https://musicbrainz.org/edit/33279425) ([raw edit data](https://musicbrainz.org/edit/33279425/data)); fully loaded
* [33279424](https://musicbrainz.org/edit/33279424) ([raw edit data](https://musicbrainz.org/edit/33279424/data)); fully loaded
* [33279324](https://musicbrainz.org/edit/33279324) ([raw edit data](https://musicbrainz.org/edit/33279324/data)); fully loaded
* [33279323](https://musicbrainz.org/edit/33279323) ([raw edit data](https://musicbrainz.org/edit/33279323/data)); fully loaded
* [33279322](https://musicbrainz.org/edit/33279322) ([raw edit data](https://musicbrainz.org/edit/33279322/data)); fully loaded
* [27257249](https://musicbrainz.org/edit/27257249) ([raw edit data](https://musicbrainz.org/edit/27257249/data)); fully loaded
* [26140528](https://musicbrainz.org/edit/26140528) ([raw edit data](https://musicbrainz.org/edit/26140528/data)); fully loaded
* [26097309](https://musicbrainz.org/edit/26097309) ([raw edit data](https://musicbrainz.org/edit/26097309/data)); fully loaded
* [22652322](https://musicbrainz.org/edit/22652322) ([raw edit data](https://musicbrainz.org/edit/22652322/data)); fully loaded
* [15894193](https://musicbrainz.org/edit/15894193) ([raw edit data](https://musicbrainz.org/edit/15894193/data)); fully loaded
* [15894153](https://musicbrainz.org/edit/15894153) ([raw edit data](https://musicbrainz.org/edit/15894153/data)); fully loaded
* [11447788](https://musicbrainz.org/edit/11447788) ([raw edit data](https://musicbrainz.org/edit/11447788/data)); fully loaded
* [11447787](https://musicbrainz.org/edit/11447787) ([raw edit data](https://musicbrainz.org/edit/11447787/data)); fully loaded
* [11447786](https://musicbrainz.org/edit/11447786) ([raw edit data](https://musicbrainz.org/edit/11447786/data)); fully loaded
* [11447785](https://musicbrainz.org/edit/11447785) ([raw edit data](https://musicbrainz.org/edit/11447785/data)); fully loaded
* [11105172](https://musicbrainz.org/edit/11105172) ([raw edit data](https://musicbrainz.org/edit/11105172/data)); fully loaded
* [7994282](https://musicbrainz.org/edit/7994282) ([raw edit data](https://musicbrainz.org/edit/7994282/data)); fully loaded
* [4573989](https://musicbrainz.org/edit/4573989) ([raw edit data](https://musicbrainz.org/edit/4573989/data)); fully loaded
* [4573987](https://musicbrainz.org/edit/4573987) ([raw edit data](https://musicbrainz.org/edit/4573987/data)); fully loaded
* [4570176](https://musicbrainz.org/edit/4570176) ([raw edit data](https://musicbrainz.org/edit/4570176/data)); fully loaded
* [4570169](https://musicbrainz.org/edit/4570169) ([raw edit data](https://musicbrainz.org/edit/4570169/data)); fully loaded
* [2917057](https://musicbrainz.org/edit/2917057) ([raw edit data](https://musicbrainz.org/edit/2917057/data)); fully loaded
* [2533558](https://musicbrainz.org/edit/2533558) ([raw edit data](https://musicbrainz.org/edit/2533558/data)); fully loaded
* [1144561](https://musicbrainz.org/edit/1144561) ([raw edit data](https://musicbrainz.org/edit/1144561/data)); fully loaded
* [911945](https://musicbrainz.org/edit/911945) ([raw edit data](https://musicbrainz.org/edit/911945/data)); fully loaded
* [191970](https://musicbrainz.org/edit/191970) ([raw edit data](https://musicbrainz.org/edit/191970/data)); fully loaded

**Time:**  2020-10-20 09:59:56 UTC

**Host:**  c681682b1419

**Interface language:**  en

**URL:**   `https://musicbrainz.org/release/9ac68a8c-0617-38a2-a5dd-a937046a38f6/edits?page=2`

**Request data:**

$VAR1 = { 'body_parameters' => {}, 'query_parameters' => { 'page' => '2' } };

But being stubborn, I started to read the edit notes one by one and then spotted this:
https://musicbrainz.org/edit/4573987

And then this:
https://musicbrainz.org/edit/4573989

# Internal Server Error

**Oops, something went wrong!**

**Error:**

Couldn't render template "undef error - TypeError: Cannot read property 'linkTypeID' of undefined at a.createElement.a.createElement.a.createElement.a.createElement.a.createElement.l.map (/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js:1:786608) at Array.map () at t.default (/home/musicbrainz/musicbrainz-server/root/static/build/server-components.js:1:786565) at d (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:36:498) at $a (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:39:16) at a.b.render (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:44:476) at a.b.read (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:44:18) at Object.renderToString (/home/musicbrainz/musicbrainz-server/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:54:364) at getResponse (/home/musicbrainz/musicbrainz-server/root/server/response.js:102:31) at Socket.receiveData (/home/musicbrainz/musicbrainz-server/root/server/createServer.js:83:31) at lib/MusicBrainz/Server/Plugin/React.pm line 18. "

**Stack trace:**

* `line`
* `line`
* `line`

**Edits loaded for the page:**

* [4573989](https://musicbrainz.org/edit/4573989) ([raw edit data](https://musicbrainz.org/edit/4573989/data)); fully loaded

**Time:**  2020-10-20 10:10:50 UTC

**Host:**  f457dcc70971

**Interface language:**  en

**URL:**   `https://musicbrainz.org/edit/4573989`

**Request data:**

$VAR1 = { 'body_parameters' => {}, 'query_parameters' => {} };

I assume I have now worked out why this bugs out? I guess there is a ticket on this somewhere… just thought someone may want to know those of us editing really old stuff (this is from 2003) trip over this now and then.

Interestingly, if swapping to test.musicbrainz.org the error is still there but different working.

kellnerd · October 20, 2020, 2:39pm

IvanDobsky · October 20, 2020, 2:42pm

Thanks for creating the ticket. I trip over the same “cannot read property 'linkTypeID” quite often, but this is the first time I chased into a “why”. Looks like old corrupted data needing better crash handling.

IvanDobsky · November 10, 2020, 6:07pm

Yay! Thanks @reosarevok - I can now read the full edit histories again. (And @kellnerd for reporting it)