Thanks to everyone who spent time testing and giving valuable information in return. I read it all from the beginning as Iām mentoring @yyoung with his project, enabling me to also answer about important points that have been discussed during the development.
As a reminder, I did push mostly existing tickets about URL editing to the list of ideas for GSoC this year, which have been investigated by @yyoung to make his own proposal. It got reviewed and approved. The current roadmap is slightly different from the initial proposal as implementation details become more clear. The current UI change is relatively small compared to the rest of the expected tasks. More insight should be provided about the overall progress of this project soon.
I love this.
(still feel strange to have the ātypeā selector under the urlbox tho, seems itāll take a lot of vertical screen estate. but I see that keyboard users prefer it.)
Updated UI layout is now available from beta website, it features both URL editing popover (MBS-11391) and grouping of edited URL relationships by external link (MBS-11680), and makes use of previously improved error messages (MBS-11698). Next improvements still in progress making use of this new layout are to support auto-select/cleanup/validation of more than one relationship type for external links (MBS-9902), to support adding URL relationship with begin and end dates (MBS-3774), and to support bypassing URL relationship validation (MBS-9040). More improvements to come in further releases.
When adding an existing URL again, this number is used as a position reference in error message to inform where the original URL can be found and where the second relationship will be added. This is particularly useful when there are so many external links that the whole field set donāt fit in the screen.
I just pasted this URL into the box and it acts the same as the current implementation and complains - bryancorbett.co.uk - a link WITHOUT any http, https or www. It is still valid, but gets rejected.
If it is typed with www. on the front it gets resolved. Would be good if that happens to other valid links like this one.
BIG plusā¦ if this is pasted into the current live website it is a PITA to fix as my attempts to add the https:// on the front are thrwarted by the GUI auto-correction. Your new interface is much better as it does at least let me type up the front of the box.
Sorry, but I didnāt get the point, do you mean the new UI introduces a new bug or it fixes a current issue? BTW, I canāt reproduce the bug, could you be more specific?
Errrrā¦ donāt know what is going on. It works now.
AH - hang onā¦ just tested something. It was PEBCAK. I was pasting text which had a bogus SPACE in front of the text. Whoops. My paste buffer was " bryancorbett.co.uk". A SPACE in front of the B.
Sorry. Though that could change to the request to remove white space from the text as part of validationā¦ Told you I find imaginative ways to bork things
OK now I can reproduce it, it exists both on stable version and on beta, and it would be better to fix it, but Iām afraid we canāt be certain about whether to add āhttpā or āhttpsā.
I canāt really answer the http vs https thing. Just use the same as you do for www. addresses. Usually if you hit a website with http it will autodirect to the https. But https is now much more common. Toss a coin.
I hit things as a ādumb userā so just try and use things. Yes, I have experience of GUI design, but all the best GUIs handle unpredictable users.
I know I copy URLs from all kinds of places. Often off of a website, so various formatting characters will be in the buffer when I paste. Your new GUI is easier to clean up text as the current one keeps putting the cursor at the end of the edit box when it is auto-correcting.
Sorry I didnāt notice that difference before. This is due to a change in layout, so itāll take some extra effort to change it back.
In the new editor you can also use Enter to submit and move focus, currently if a type is automatically selected, the focus will go to the next input box, otherwise itāll go to the type selector. Maybe we can make it go to the checkbox as well, Iāll look into that soon, thanks for reporting.
I wonder if itās worth adding ātabindexā attributes to these pages to make it easier to change up in future/to avoid ever having to rearrange tables.
I tested that on test.musicbrainz.org/artist/<MBID>/edit
The behaviour when you press enter in a field is usually (and currently on MBS) to submit the form.
I usually press enter on one of the URL to submit the Edit artist page.
It seems a little strange to me to expect pressing Enter in a field for anything else than submitting.
The test server has not been updated for a long time.
Unfortunately we have to use that for links submission and merge confirmation as for now, but you could still press Enter in an empty field to submit the form.
Overall it looks good, though I think the current layout is a bit messy:
Current Beta:
Mock up showing what I would prefer (but thatās just me):
Among changes:
move Add another relationship under existing relationships
invert position of delete / edit icons (like they are just above in this example)
add a separator to ease reading
I feel the ? icon isnāt needed, the entity could display it on rollover directly (for example, BBC Music ? could be replaced with just BBC Music, but still displays extra infos on rollover)
Just a quick feedback, the whole thing is quite an improvement already (finally only one Bandcamp URL)
Also, whatās the purpose of numbers? If they are here to stay, they should be first (from the left), as it is usual for numbered lines.
Not had time to test yet, but one question. Why is the interface not consistent:
Compare top part of screen to lower part. Are all pencils now going to the end of the line instead of the start? Are they tidier at the start of the line?
BTW, I canāt reproduce the bug, could you be more specific?
