Found another color setting that might work. Is the below better visible to you?
Yeah, that one is better.
Seeing the comparison between all these themes in the previous post, Iām clearly using the one for which your extension has the worst contrast
Yes. Unfortunately it is the dark variant of the default theme The other ones are also themes Discourse does include by default, but they are not available here in the MB forums. But I do test with them on my local dev setup.
But the new color variable I chose looks better in all those variants, so Iāll use this now. Thanks for the feedback!
I thought of another potentially useful feature (I hope weāre not entering feature creep, and in any case feel free to ignore the suggestion of course): showing the userās currently pinned listen if there is one, with a fallback to one of the other modes.
At this point it will become hard to phrase in the preferences dropdown: āCurrent pin with fallback to most recent listen or user profile statisticsāā¦
I suppose the length of the accompanying text (if any) could become an issue:
As for the API side, thereās currently no great way to get the currently pinned listen : you need to get all pins for a user (https://api.listenbrainz.org/1/mr_monkey/pins), then compare the pinned_until
timestamp of the first item in pinned_recordings
to the current timestamp to determine if it is still pinned.
Iām happy to implement a better endpoint that will return only the current pin for a user, it seems to me that it would be a lot less cumbersome for such a case.
Indeed I had thought about doing something with the pins, but because of the API I decided against it. Iām happy to implement something in the plugin if there is a proper API that can give me the pins Ideally something that I can limit to a single result of a pinned recording.
Iām sure I can come up with some way to better represent this in the settings.
Iāll likely restrict it in some way or make it expandable.
And @lucifer swooped in and fixed that!
You can now directly get a userās current pin: https://api.listenbrainz.org/1/outsidecontext/pins/current
If there is none, pinned_recording
will be null
Thanks @lucifer . Iāll see how I can make use of it for displaying the pinned recordings. ~phw/discourse-listenbrainz#7: Pinned recording info card ā sourcehut todo
Iāll need some time until I get to this, though.
I implemented showing the current pin:
For the preferences I decided to make this an extra option for the recent listen card. It shows the current pin or if there is none falls back to the listen.
This will be available here once discourse and the plugin get updated. @zas
ListenBrainz plugin upgrade applied (0.13.1).
0.13.2 was deployed.