Notes from #MetaBrainz Meeting 2023-07-24

[aerozol]

MetaBrainz Meeting 2023-07-24

Meeting start: IRC Logs for #metabrainz | MetaBrainz Chatlogs
Meeting wiki page: MetaBrainz Meeting - MusicBrainz Wiki

Agenda

• Reviews
• Docker

Last meeting: 2023-07-17
Next meeting: 2023-07-31

@reosarevok: Hi everyone! It’s Monday again and we have gathered to regale each others with tales of our prowess

Reviews

@rob

(mayhem) last week I focused on lb-radio, which is now available for testing here: https://datasets.listenbrainz.org/lb-radio
I would very much love it if people could give it a try and tell me what you think of the generated playlists.
I also worked on PR reviews, lb content resolver, and moving recommendations along.
which we released today – thanks for monkey and lucifer for all the help!
Created for rob- ListenBrainz
looking perty!
[and thanks for the designs aerozol]
we immediately found a few minor bugs that will be fixed in the coming days.
finally her. believe it or not, this is what I set out to do 23 years ago, but realized that MusicBrainz needed to exist before I could do this.
So 20 years later, I could finally start working on that. and today we delivered.
loong road was long, but I’m very happy with what we’ve created. and loads more to come!

@mr_monkey

(monkey) Last week I continued reviewing and moving the GSOC projects along
Also finished some long-opened PRs for BookBrainz and deployed to beta
And more PR reviews
That’s me in a nutshell (let me out!)

@reosarevok

I mostly worked on style issues last week, since I felt I hadn’t looked at them enough recently
Other than that, we had a couple long-ish meetings with the MBS team and we hopefully figured out needed improvements for the DB schema docs
Today I got a lot of PR reviews by yvanzo so I’ve been dealing with that and will probably do more of that after the meeting and tomorrow : )

@CatQuest

(AppeKattQuest) Doing lots of AFK stuff on vacation. seems the whole of europe is burning up but here we are drowning in water (it’s better than dying of heatstroke though.)
Tried adding some stuff and suggestions to the comparison table doc aerozol made (ORG-52: Feature comparison table)
that’s it for me, i’ll be afk and on again with instruments this week too♋

@snaekboi

(Pratha-Fish) Last week was great!
Made some progress on a new feature (edit existing areas on MusicBrainz) for the MusicBrainz bot
Started exploring and implementing new scripts to fetch areas from wikidata
Broke my testing setup YET AGAIN and spent wayy too much time fixing it (making progress thanks to yvanzo
:))
interestingly enough, I’m also onto some unexpected developer relations work. I’ll be conducting two sessions at one of the best universities in India where I’ll be guiding folks on how to make their first contributions in open source!
(using the Musicbrainz codebase ofc ;))
Finding some ridiculolusly easy bugs to solve live rn
Also, I went to the hills and almost died in a car crash, missing my last weeks meet

@jasjeet

(jasje) last week i got my similar listens pr merrged
fixed listen submitter little bit and saved listens ti submit later
shrinked the code for submitter as well
continued with my gsoc project
I’ve been eyeing on making some changes to the designs as well (image)

@bitmap

last week I finished deploying new postgres (standby with streaming replication from floyd), pgbouncer, and haproxy containers on jimmy and peformed some benchmarks
current changes are in the ‘ha’ and ‘ha-pg’ branches for docker-postgres-cluster and docker-server-configs respectively
performance appeared to be very good and within expectations, but I understand some further optimizations are needed for zfs
the main architectural change is that pgbouncer will point to haproxy instead of postgres directly, and haproxy will detect which pg node is the primary. it should simplify switchovers a lot and reduce the amount of downtime needed
otherwise I mainly just reviewed the database schema doc/diagram changes from yvanzo that reosarevok mentioned

@yvanzo

Happy International Self-Care Day.
Two MB dev meetings (reosarevok and bitmap mentioned) helped with finally updating the MB PostgreSQL database docs to schema 28 (2023 Q2).
There still are a few undocumented areas, but it’s much more complete and consistent now.
Implemented CORS support for LB to use wikipedia-extract.
Also reviewed a bunch of MBS PRs, plus some support.

@zas

I came back from a train trip on Wednesday, so the week was rather short
We (with atj) upgraded docker on all servers
(more on this after reviews)
I also reviewed PRs for Picard, 2.9 should be released this week
plus usual supervision, minor fixes, services restart

@lucifer

last week, i worked on finishing up the tags dataset and generation of weekly playlists.
some PR reviews and gsoc discussions.

@akshaaatt

I’ve been reviewing PRs as usual
Kudos to jasje for working on multiple things!
Also, on the iOS app side, theflash added Shazam support which can listen to any song being played to identify it!
That’s really cool
With strong support, we are moving swiftly on both sides
Other than that I’m still juggling with my life with my head inside water

@atj

not much to report this week - I just helped out zas with some docker role updates and had a quick look at some zfs / postgres stuff

@kellnerd

Last week I completed my first clean-up round of the bookbrainz-utils/importer repository.
Using my freshly setup minimal test database, I was able to simulate the whole import process and could track the remaining error back to the ORM import functions in the bookbrainz-data package.
As my next task is to debug the ORM functions, it finally felt like the right time to create a “feature-complete” PR:
https://github.com/metabrainz/bookbrainz-utils/pull/40 contains the new BookBrainz Import Queue (BBIQ) management CLI!
(which should work once I’ve fixed the underlying ORM functions in the other repo)
I’ve tried my best to document the changes to make this beast of a PR reviewable for monkey.
Other than that, I’ve discussed the new “audio director” relationship type with reosarevok and aerozol which I had been eagerly anticipating for years

@ShivamAwasthi

Last week I made improvements to the Admin Logs PR, taking in a lot of feedback from monkey, ansh and kellnerd.
I also did some work on the type-editors. As reported last week, I had started doing some work to create Relationship Type Editor and Identifier Type Editor as separate components but…
after some thought, I think it would perhaps be better to create a general editor called the ‘Type Editor’, which will have modularity similar to the Entity Editor.
I think this will be good for expanding to other types such as Work Types, etc.
So I started working on that front

@arsh331

(arsh) I spent my last week finishing up the artist search for the interactive graph project and submitting a PR for the same
Spent the remainder trying to build the layout for the artist info panel for the same
And some bug fixes in my existing code

@vardansaini

(vscode_) I worked on improving the workflow as mentioned by Lucifer
I will be pushing that soon
I have been working on tests as well which will be push later this week

@vishalftw

(pixelpenguin) Last week I worked on setting up select options in Dataset Hoster UI based on the implementation suggested by lucifer There was some issues with my local setup which are fixed now. I will try to add the commit by tomorrow.
This will allow to test all the changes I have made in UI as well

Absent: riksucks (3) (removed from the meeting regulars, re-add yourself when you’re around again @riksucks)

Docker

@zas

We upgraded docker
this version fixes an issue related to live restore and network
but for it to fully apply containers need to be restarted
so we need to plan a small downtime in order to restart all containers
if the core team is around tomorrow we could do that around meeting time

It is clarified that all servers/containers will require a downtime.
It is agreed to do it next week, one hour before meeting.