Notes from #MetaBrainz Meeting 2021-10-25

[Freso]

#MetaBrainz Meeting 2021-10-25

Meeting start: IRC Logs for #metabrainz | MetaBrainz Chatlogs

Disarmament Week Monday

Who Would Jesus Bomb?

Agenda

• Reviews
• Follow up on Summit Notes → Tickets
• Allow test editing without verification
• Allow account admins to see editor-editor subscriptions?
• Removing empty accounts - last
• Next meeting PSA

Last meeting: 2021-10-11
Next meeting: 2021-11-01

Reviews

@yyoung

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yyoung

• Last 2 weeks I worked with the MB dev team to get my open PRs merged, and opened a few tickets about MB and LB.
• Apart from that, I played with musicbrainz-bot and wrote a script for MBBE-50, I’m planning to automate more URL-related work with it.
• Finally I tidied up 2 importer scripts that I’ve been personally using for a long time and released them earlier tonight.
• That’s all, thank you.

@rdswift

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@rdswift

We transferred the Picard Documentation from my personal repo on GitHub to metabrainz

@alastairp

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@alastairp

last week after the summit I spent some time in a resort town up in the north of spain. it was nice. I rode my bike
I did some further experiments with metadata submitted to LB, trying to work out what additional_info tags various submitter programs use. in short, most of them submit the bare minimum, or file-based ones submit all metadata tags. interesting, need to look into it more
then I fixed brainzbot, and did some planning with @lucifer and (I forget! @yyoung?) to make some deployment improvements and fixes to the terrible archives view
I didn’t make any tickets based on discussions from the summit

@zas

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@zas

apart usual supervision & upgrades, I did a lot of little patches on various projects
I fixed caa-admin
I wrote small patches for Picard, did some PRs reviews too
I resume work on serviceregistrator, I expect to deploy it this week (at least on non-critical machines)
plus various patches on openresty-gateways & docker-server-configs

@bitmap

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@bitmap

last week I continued with the artist credit editor refactoring I mentioned a couple weeks ago to make it usable in newer edit pages
and worked on fixing some issues in the AcoustIdCell and TaggerIcon components
I started writing a selenium test for the TaggerIcon since we didn’t have any
I also submitted a few PRs to musicbrainz-docker while trying to reproduce MBVM-49 for @yvanzo
and otherwise was mostly testing prs/doing code review

@lucifer

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@lucifer

between the last meeting and the summit, i mostly worked on huesound with ruaok, akshat and monkey. i also did some minor cleanups in LB code, small bug fixes in the last two weeks. I had two interesting debugging sessions - one to fix all time release stats (rabbitmq again)
and second to fix listen counts which were preventing the LB user pages from loading for some users.
I also worked on upgrading stripe checkout integration in the metabrainz website.

@rob

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@rob

last week was a diverse week.
as per @alastairp’s instructions, I created a graph that went up and to the right:
Grafana
(see bottom)
unlike @alastairp, I kinda took the very long and convoluted way of generating data for it, required some dozens of volunteers each day to scan in a pile of images.
a bit tedious, really.
so, the CAA color mapping is now being kept up to date automatically.
and I feel a lot more confident building these sorts of things now. the tools are pretty well established now.
then I attended the kick off meeting for the ODI peer learning network, which then netted me 17.5 hours of zoom in 4 days.

and the ususal background metabrainz guff to drag along. like finally trying to finish to get the phone line at the office but into Meb’s name. total BS stuff.

@akshaaatt

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@akshaaatt

I have finally made a draft PR to MusicBrainz regarding the revamp, and things are working great so far. I had to make subtle changes but the decision of carefully working on the project separately and then integrating it once a section is done, is a win.
I migrated my mock work from a CRA to a next js project for my better understanding of things. I have concluded that while nextjs is neat and fine, the way MB is managed is way more superior and flexible so I am really happy with that.
I had the opportunity to connect with some devs who follow mb and they provided some good feedback into stuff.
I have added a barcode scanner to the mock work and it seems amazing to just click the scan icon on the homepage, have your barcode read and get the release. Works on webcams as well as mobile camera!
Some good LB work upcoming soon and was happy to be a part of huesound as well.
Other than that it’s festive time here in India so great vibes!

@reosarevok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

After the summit I mostly concentrated on a few small PRs
To relax a bit
This week I plan to look into migrating more of the edit display pages to React now that all the actual detail info is ported (so, edit index and edit list)
Hopefully that’s already not blocked by anything else

@CatQuest

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@CatQuest

Last week I worked on complicated instrument aliases.
also I finished compiling a list of missing locales (of atleast the ones I’ve seen on instruments)
eg [MBS-5150] Several languages/locales missing from alias list (Latin, Scots, Scottish Gaelic, ...) - MetaBrainz JIRA
I hope we can do something about letting in (at-least) these locales asap. Several of these are ones I find time and time again on instruments and it’s a real pita not to be able to include them.
This week I will be mostly afk because of allehelgensaften celebration

@mr_monkey

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@mr_monkey

In the past two weeks I continued the refactoring of BrainzPlayer and various ListenBrainz front-end pages and components (listen card, playlists, pinned recordings). It was really helpful to bounce off some react architecture ideas with @alastairp
We’re slowly gaining functionality and homogeneity on the LB pages; after the pending PRs are merged only the reports page will remain to be refactored, but that requires first refactoring the BrainPlayer UI, the next big chunk I have to tackle.
I also helped bash out a page for the huesound project which was a nice distraction
I prepared for the summit and made sure to have my up-and-to-the-right material ready. Summit happened and it was really nice to see you all!
I fixed some issues with the BookBrainz Docker image build and set up, with the goal to deploy @akashgp09’s GSoC project of Series entities, which I just deployed this evening!
I also reviewed PRs and did some general repo upkeep and housekeeping [cue Queen’s I Want to Break Free], and 12 minutes of something I wrote down as “Misc.”
And finally, I spent a moment investigating adding album covers on listens in ListenBrainz, which opened a can of worms (oh no.). We’ll get to it soon™ though.

@Freso

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

Dealt with some reports/flags, assisted @yyoung with some Discourse stuff, prepared for summit, attended and streamed summit, and spent a lot of time on downloading the day 1 video, obscuring like 2 seconds of it, rendering the thing, and re-uploading it. It now lives at MetaBrainz Summit 2021, Day 1 (Saturday) - YouTube
If you posted the stream URL anywhere, consider going back and edit it to point to that one instead if you can.
Oh!
And I did a bit more dev’ing on the ListenBrainz add-on for Kodi. I would love to have an LB person look at Advertise add-on as client to ListenBrainz (#23) · Issues · Freso / service.listenbrainz · GitLab whether that makes sense as per the suggested spec.

@yvanzo

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yvanzo

I reviewed pull requests and fixed my pull request about URL examples.
Helped bitmap with investigating some issues through musicbrainz-docker.
Updated Jira Server integration to work with the new Sentry instance/version with @lucifer’s help.
Updated Jira add-ons (might be related to the reportedly broken auth using GitHub).
Temporarily disabled email sending from test.mb.o which was likely used by scammer.
Restored search indexer service too.

Follow up on Summit Notes → Tickets

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@lucifer

just a reminder that we need to go through the summit notes and creates JIRA tickets for them.

Allow test editing without verification

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

@yvanzo had to disable verification emails on test.mb, as he mentioned, because it seems it’s being used by some dodgy asshat
But in any case, verification in test has always been dodgy - everyone can see the verified email by editing the user, IIRC, and the user does not get notified
But you can’t edit with a new account without a verified email
(existing accounts have no email set)
(but are marked verified)
So, we were wondering, should we make it so that there’s no verification requirement at all for editing in test?
As in, no email needs to be entered

It was confirmed that test.mb uses a dummy database and given that, there were no objections. Additionally it was suggested that the e-mails that do get added to test get wiped periodically. Also possibly to have a test e-mail address specifically for this.

@reosarevok agreed to make a ticket for this.

Allow account admins to see editor-editor subscriptions?

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

One thing sockpuppets often do is follow other sockpuppets. Sometimes those sockpuppeteers are clever enough to mark their subscriptions as private.
Being able to see which editors an editor is subscribed to can sometimes help untangling some of these webs.
But I’m not sure if this is getting too intrusive?

It was noted that most of the MetaBrainz team already has direct db access so they could look this up if they wanted to and @mr_monkey mentioned a possibly applicable part under Exceptions of our Privacy Policy. @rob said he was okay with this and no other objections were raised.

Removing empty accounts - last

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

So, we talked about removing empty editors during the summit
And about how I would bring a query to the next meeting for review
So, I’m still working on the script that will run the query (since we can’t just delete editors directly with SQL without dealing with FKs first, we’ll use the delete method for editor in a Perl script)
But the query itself currently looks like this
gist:b0e1ad2e461810d935b56d060c6a1ebb · GitHub
I’d want people to take a last look to make sure we’re not forgetting anything stupid
It currently hits 782014 editors
It will still go through code review so we’re not going to rush into it, but since not everyone does MBS code review, but maybe @Freso, @lucifer or @rob might see something dumb
And then decide whether to write to them or not
That’s probably it for now, just “this is here, take a look, I’ll bother you again before we run it”

Next meeting PSA

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

This Saturday/Sunday Europe will stop observing daylight savings time, so anyone who is not sync’d with Europe in this regard (e.g., Indians, Turtle Islanders/North Americans) will have the meeting be an hour different next week.
I can’t math right now, so not sure if an hour earlier or later.

It’s an hour later (thanks @lucifer ).

The applicable times can always be found at:
https://wiki.musicbrainz.org/MetaBrainz_Meeting#Regular_Meeting_Time