Notes from #MetaBrainz Meeting 2018-05-28

[Freso]

MetaBrainz Meeting 2018-05-28

Meeting start: IRC Logs for #metabrainz | MetaBrainz Chatlogs

Agenda

• Reviews
• Gendered speech
• Dropping Gravatar

Reviews

@iliekcomputers

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@iliekcomputers

Worked on the LB GDPR release. Also worked with rashi on setting up and debugging some of her work.
Currently in andaman Islands with no internet. Be back on the 2nd of June.

@bitmap

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@bitmap

Worked on implementing the MBS portion of MBS-9680 and tested it against the BookBrainz PR. Reviewed the LB one, but need it needs some changes first and I’ll need to setup LB too.
Also did some code review and worked more on i18n issues in my PR converting the homepage to React.

@yvanzo

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yvanzo

I released a new MBS beta, addressed some MBS issues (mostly regressions), helped @Freso with discourse plug-in, and worked on spam things (reports and spam data).

@Leo_Verto

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Leo_Verto

I helped review the last couple GDPR things we needed
And talked to @yvanzo about how to send me the spam data
Other than that, had a presentation on Friday and a workshop on the weekend so not much else got done

@shivamt

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@shivamt

This week I set up general architecture to utilise multiple processors (to be used for both producers and consumers)
I have tried to make it very modular so that it could be reused again.
I then explored dumps, extracting out all unique fields in the json records.
2.5G+ dumps get processed in around 30 sec time on my laptop, which is acceptable I think.
I also setup rmq and pushed processed records into it. It’s still a WIP.

@chhavi

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@chhavi

The usual. Design system, some mockup iterations, and a little summit artwork. Other than that, spent some quality time at home, which was good

@samj1912

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@samj1912

spent most of the week on getting SOLR up and running
we are very close to a feature parity (infact a much much better search)
had a couple of set backs, reported a solr bug, but meanwhile worked on reducing code duplicacy and getting a workaround sorted for the said bug

@Rob

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Rob

GDPR, GDPR and GDPR. With a dash of GDRP for good measure.
really, that was it. I worked with @iliekcomputers on the LB GDPR changes (which took some getting right, sorry @iliekcomputers)
and did a modicum of minor other things.
but, as I just said to @chhavi, if you need me for something, ping me soon.
I’ll catch up on PRs this week…

@zas

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@zas

nothing fancy this week, just upgrades, IP unblacklisting, nagios tuning, pr the like

@reosarevok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

I’ve been working on uni stuff mostly (final deadlines June 1st)
And helping @samj1912
I also had a nice email chat with setlist.fm support people, they will try to add more info about how to do stuff so people do not change MB when MB is right

@Freso

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

I spent a bit of time looking over our various new GDPR documents as well as looking into GDPR compliance for the Discourse forum.
Dealt a bit with some reported editors/users.
And looked into abbreviation plugins for Discourse too, after requests from users.
Since there wasn’t anything I felt comfortable with readily available, one of the Discourse founders suggested porting another “theme component” that functionally did something similar, and it turned out to be pretty easy to port that, so now we have:
GitHub - metabrainz/discourse-abbrify-words: Discourse theme component for automatically adding <abbr> to abbreviations and acronyms
Other than that, hanging out on IRC and forums.

@little_rsh

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@little_rsh

Last week I worked on the recording entity script for the direct connection with MB. And I started my work on the second method of database access (copy the MB data in AB)
Started with creating a separate musicbrainz schema in AB database with all the relevant tables we would need in AcousticBrainz and then I wrote a script to test the import of small data from MusicBrainz for the recordings present in AB and am able to retrieve it and write to MB schema in AB over the direct connection and tried it with sample dumps.
I would probably complete the method of importing the MB data by the end of this week.

@kartikeyaSh

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@kartikeyaSh

Finally, I got home on Wednesday from college. I created a script for creating clusters of recording LB-367.
I worked on the reviews of @iliekcomputers on BU-11. And I got LB-352 reviewed today by @Rob. So I worked(still working) on the changes suggested. Some of these reviews apply to LB-367 too. So, I’ll have to make changes in LB-367 too.

@ApeKattQuest_MonkeyPython

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@ApeKattQuest_MonkeyPython

mostly I’ll be doing nothing except playing in a river today :D, also nothing to report, next week will be tackling much instruments!

Gendered speech

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Rob

I was reading some code a week ago or so and saw a comment in the code that gendered speech.
what this amounts to is making references to “him or her” instead of just using “the user”.
then I looked around a bit and of course it wasn’t really balanced between the two genders.
in university I was taught to alternate between the two for fairness.
but in code, that makes little sense since things move around. the whole thing seemed silly.
there is no really need to use gendered language in our work.
so, I propose the following new rule to apply for everything that we do.
code, documentation, bugs, etc.
“We shall aim to avoid gendered speech whenever possible, unless we are actually talking about the topic of genders. Going forward all code comments, documentation, bugs, etc should use non-gendered speech”.
finally, when we touch a piece of code we should clean up the language as we see fit.
so, if you see some gendered speech when doing a code-review, please point it out as needing improvement and request changes.
ideally, we could do the same when talking about edit notes and so forth.

After some questions concerning edit notes (ie., how broadly it’s meant to apply), @Rob assured that he doesn’t mean for it to apply when directly talking about editors or artists with known genders, but rather for when discussing editors in general (e.g., «If an editor wants to do this he should do it this way»).

A number of people agreed with the proposal, and no one spoke against it, so motion was carried. @Rob said he’d «submit a PR to the [Code of Conduct] in the coming week to codify this as official policy.»

Dropping Gravatar

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Rob

I guess, really this isn’t much of a decision, but an official announcement.
I’m sick of this debate, I’ve asked @bitmap to remove gravatar support from MBS.
and in the context of GDPR, it just makes sense.

There was discussion about whether to try and implement using the avatars users have at https://community.metabrainz.org/ instead. @Rob stated that he didn’t care either way about that, he just wanted Gravatar gone now.

[MaxScott]

Why have been gravatar removed?

[reosarevok]

@MaxScott

Why have been gravatar removed?

Gravatar was reasonably controversial since its implementation because of its potential privacy issues, which led to it being made optional. With GDPR and the push on user privacy, we decided these issues are more relevant than ever, and we’d rather play it safe and get rid of a service that wasn’t that popular in the first place. We’ll probably add a way to use the avatars from this forum instead at some point, see the MBS-9725 ticket