Notes from #MetaBrainz meeting 2018-02-19

[Freso]

MetaBrainz Meeting 2018-02-19

Meeting start: https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123624/

Agenda

• Reviews
• OTHER-77: MarkBrainz
• Design system POC

Reviews

@chhavi

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123636/

@chhavi

This week, I wrapped up the Artist page from my side. If feedback goes smooth, we should finally be done with one entity that we started designing back on September
Will link in the ticket in a while
Other than that, worked/researched more on our design system. More about it later in the meeting

@CatQuest

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123643/

@CatQuest

Finally got my macomputer back \o/
So most of this week was spent sorting it out and setting up the music playing (since my other mac (the macmini, which was what was playing the music) went tits up a week ago as well ë_ë)
sadly I got ill on friday so I’m still couching and sneezing now. but I’m slowly on the mend luckily!
From this week on I hope to be doing intervals of hyperion releases and instruments from gci :​​​D
since I’ve borrowed “hyperion” release from thel ibrary, and as they have mostly older releases (90’s and 80 cd’s :O)
I hope it’s useful

@reosarevok

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123655/

@reosarevok

I’ve been dealing with support mostly
Quite a few people asking for IDs again, wonder why these seem to come in waves
Style-wise, I literally just fixed https://tickets.metabrainz.org/browse/STYLE-924
And as part of the hyperion cleanup, https://tickets.metabrainz.org/browse/STYLE-916 came up, which I fixed too
Plus zas pestered me about https://tickets.metabrainz.org/browse/STYLE-914 so that’s changed too
I’m currently looking at more style, so expect a few more tonight!
Plus I’ve been trying to add new hyperion albums as part of the cleanup
Outside MB proper, I somehow ended up being voted to the board of Wikimedia Eesti. So that’s going to be fun.

@Rob

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123672/

@Rob

more of the same for me, a kinda odd quiet routine.
board/taxes stuff, phone calls, some accounting BS, listlessly poking at the annual report.
LB PRs and trying to get the next beta up and running.
and yes, strange waves of supporters is common too.
nothing that tracks holidays or other things in the normal world.
just 5-6 people in 2 days and then silence for 2 weeks.
I can’t put my finger on it.
I’ve got an ISNI call this week that should be interesting is well. talking with OCLC and I’m basically going to tell them that we can’t work with them until they actually guarantee to keep their API up 24/7
this every few weeks the API going dark for hours on end has got to stop.
finally, here is an interesting article on Open Street Maps I wanted people to take a look at:
https://blog.emacsen.net/blog/2018/02/16/osm-is-in-trouble/
the OSM thing is kinda hard, because we have similar natures.
and all the things I see that are difficult with OSM are because hosting the data and a service would be immensely difficult for them.
which made me really proud that we can host our own data.
and that is in larger part due to @zas never taking his eyes off the servers.
so, @zas, stand up. please take a bow. you make our shit work. THANK YOU.

@zas

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123716/

@zas

This week was mainly merging a bunch of Picard PRs, thinking about its crappy plugin system, and the way we could improve it, etc…
Of course, we had a bunch of server issues, but nothing abnormal
we had this OOM issue with web service containers, which is now mitigated by setting memory limit to containers
i added a bunch of new graphs in Grafana, mostly https://stats.metabrainz.org/dashboard/db/containers-memory?refresh=1m&amp=&orgId=1
and tuned some others
apart that, i upgraded openresty + lua ssl to last versions
plus usual upgrades

@Freso

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123729/

@Freso

Trying to keep up with IRC etc., handled a support@ mail, poked at some possible/potential editor conflicts.

@bitmap

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123737/

@bitmap

I spent most of last week reviewing react prs from samj1912 and spellew
very appreciative of their help
spent time fixing up spellew’s prs and trying to get them merged, got the one for the NotFound pages in
improved our eslint setup a bit more so the computer can yell at people
samj1912 appreciates the linter yelling at him and then fixing stuff itself
rebased and made fixes to some of my other react-related braches/prs
made our ws logs slightly more quiet by fixing some perl warnings
worked more toward draining our caa error queue and re-deriving 1200px thumbnails for releases missing them (still about 600k left; I’m probably gonna spend an hour writing a script to automate the rest)

@yvanzo

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123755/

@yvanzo

I debugged MB OOM issue, reviewed pull requests to MB and MeB Design System,
fixed ancient request for linking to Musixmatch (2015 is a vintage year for issues),
fixed tickets (JIRA) permissions (again).
I also looked into the details of OTHER-77, I will give more details at the end of this meeting.

@samj1912

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123771/

@samj1912

This week was mainly spent working on MBS and MeBDS(?)
ported stuff to react, learnt react, helped chhavi_ with some react…
basically react
also, learnt more of MBS perl/server code while porting
so fixed a couple of bugs there
Addendum 1: also organized this awesome VC with ruaok on GSoC applications last week
Addendum 2: wrote https://hackernoon.com/the-one-stop-guide-to-easy-cross-platform-python-freezing-part-1-c53e66556a0a (which received waaaay more love than he had imagined and got featured in a buncha places)

@vishalchoudhary

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123785/

@vishalchoudhary

This week i was working mostly on PICARD-1194 and PICARD-1196.
And also trying my hand on cover-art section of picard.
But due to academic exams not able to give my full

@iliekcomputers

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123795/

@iliekcomputers

I did a bunch of work to try to get the dumps we created upto the ftp server for release
I have a better understanding of how this works in production for musicbrainz now and I managed to get it done somehow
Fixed a bug which was causing the docker images to not get built, added ssh keys and did other things.
We have our first dumps here (although, I guess we don’t want to officially announce until after the new beta release): http://ftp.musicbrainz.org/pub/musicbrainz/listenbrainz/fullexport/listenbrainz-dump-20180217-103402/
Also, did a bunch of code review on CB (and some on AB just now), working with ferbncode to get PRs merged and closing old PRs.
CB PR backlog has been reduced to 5 from ~13-14. Gonna work on merging another one tonight.
Right now, trying to fix a LB bug that should be the last one ideally before the beta release.

@akhilesh

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123815/

@akhilesh

This weak I read about bookself orm and try to understand schema of bookbrainz.
Making efforts for adding statistics page in Bookbrainz site.
read a little bit about koa.js for Bookbrainz API. Welocome if anyone suggest some good resources for koa.js

@Leo_Verto

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123831/

@Leo_Verto

I start setting up a fresh BrainzBot setup on a new Google Cloud instance
which mostly involved coming up with a sane(r) directory structure
not much else this week

@rsh7

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123841/

@rsh7

This week I have worked on adding a new feature that includes asking svm parameters for training model from the user before evaluating any dataset in AB so that the search space for people can be reduced.
I also opened some PR’s for bug fixes, which make dataset and class names fits in ranges and another one which make the login option available on error pages.

@LordSputnik

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123848/

@LordSputnik

This week I’ve been continuing with the relationship editor
I feel like it’s going in the right direction, and the structure is a lot more elegant than two weeks ago
The next step will be making it load up correctly when editing an entity (it currently works for creating only)
And then update the server to process the relationship data

@dpmittal

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123864/

@dpmittal

I conducted a small survey on CB by first explaining about MeB and CB to my friends (who are in college band and are really passionate about music) and then asked them to use CB and then asked them some common questions. Their replies gave me some ideas and pointed out some prospective new implementations which I wanted to discuss upon with iliekcomputers and ferbncode for my SoC project as well (Most probably after the meeting).
This week I also sent a PR on the outdated docs and CB-252 and was also trying to make myself familiar with CB codebase.

OTHER-77: MarkBrainz

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123871/

@yvanzo

One of GSoC 2018 ideas for MB is about editing interface for event setlist. Actually, it will probably impact its storage and its display too. Event setlists are stored as constrained text with a unique syntax that can easily be replaced with Markdown. (I wrote a 1:1 equivalence proposition already.)
This is why I looked into OTHER-77. Additionally, @naiveaiguy, Daniel V. and Enjeck C. attached preliminary comparisons between some Markdown flavours during GCI contest.
Having a derivative of CommonMark similar to GitHub Flavoured Markdown (GFM) seems to be the way to go.
There are third-party extensions to Python implementation of Markdown (for CB, Picard).
There are plenty of JS implementations (e.g. https://github.com/chjj/marked ) of Markdown/GFM (for BB, MB).
I would like Python coders to look into these extensions if possible.
For example, CB supports CommonMark’s links with angle brackets, not plain auto links (that is GFM extension).

Design system POC

https://chatlogs.metabrainz.org/brainzbot/metabrainz/msg/4123900/

@chhavi

So, those of you who are just catching up, I will quickly sum up the story so far
For the redesign of MusicBrainz, we have decided to follow a component driven development. Just a fancy word for dividing the interface into parts, and build those parts. Those parts that can be reused, modified, tested individually.
We have been toying with the idea of whether we want to write our own React-components, or use react bootstrap. Yet to reach a conclusion on that one.
The other challenges that are there are, how do we maintain a sync between how it looks in mockups vs how it looks in code, describing properties/ behavior of a component, testing those components in an isolated environment, documentation.
React-storybook is something that is being used heavily for the above mentioned.
So, I tried setting up a mini version of it for us. Used react-bootstrap and css from our lobes theme. Thanks Leo_Verto for that one!
Here is the link:
http://chhavishrivastava.com/POC
It just has buttons, but imagine it being extended to all the other components as well.
This also solves the issue of waiting for our port to React to test out components. And easier for code noobs like me to test the components, make sure they are in sync with the design, etc etc!
(@samj1912: and also other things like testing, documentations and how to use components )
If you find it hard to imagine, here is one of the good ones out there.
http://react.carbondesignsystem.com/?selectedKind=Accordion&amp=&selectedStory=Default&amp=&full=0&amp=&addons=1&amp=&stories=1&amp=&panelRight=0&amp=&addonPanel=storybook%2Factions%2Factions-panel

@samj1912

if you click on show info to the top right you can see how it generates docs
it picks up props automatically, as for the rest you can type docs while writing code and it renders em up all nicely
there are other advantages to this too
we can also do some neat testing - https://storybook.js.org/testing/react-ui-testing/
(@chhavi: There is still work in it. Like modifying the css to match our mockups, new components that aren’t there in react-bootstrap, etc. Will keep workin on it.)