More serious bug concerning edition groups

indy133 · March 5, 2022, 2:55pm

If you add a new edition with an existing edition group this edition group is not shown:

A duplicate edition group is created every time. I think there already a few dupes because I just noticed it now:

This should be fixed asap, I think.

mr_monkey · March 7, 2022, 11:07am

THanks! Indeed something is not working as expected, and I’ve replicated the issue on test.bookbrainz. I’ll investigate the issue in priority.

mr_monkey · March 8, 2022, 2:50pm

Sorry @indy133 I spoke too fast, I replicated normal behaviour and thought something was wrong.
With more sleep I realize it’s working as expected for me (edition group with the same name is shown and can be selected):

If you can still reproduce the issue, could you please send the contents of your browser console as well as your browser name and version?
I’ll try to replicate the issue with that info.

It is also possible that this was a transient issue (maybe the search server was feeling tired?), which we should also handle.

indy133 · March 8, 2022, 3:45pm

Interesting, no changes here: esxisting group is not shown:

Google Chrome: Version 99.0.4844.51 (Offizieller Build) (64-Bit)

But if I’m the only one with this problem: I just use the “Search edition” function for now.
I just tried Firefox: same problem.

mr_monkey · March 8, 2022, 5:13pm

Ah, I may have found the difference:

If I load this page (with the name added in the URL), it looks like the search for an edition group is not performed: Log In - MusicBrainz
Consequently no matching EG is shown.

Now if I modify the name —for example deleting the ‘s’ at the end, then typing it again— the search is performed and the matching EG is shown.

Can you please confirm you are seeing the same thing?

indy133 · March 8, 2022, 5:21pm

yes confirmed.
When I change the title once, the edition group appears.

mr_monkey · March 8, 2022, 5:31pm

Thanks for the help debugging, that narrows it down nicely and I’ll work on fixing it tomorrow

mr_monkey · March 10, 2022, 1:10pm

So it turns out this is not a regression, and it never worked for editions (when we pre-fill the name in the URL).
Another issue is that the possible duplicate search (the one that shows up under the name) also was not triggered.
See for example: Log In - MusicBrainz
Same as before, if you add a space in the name, or delete and re-type the last letter or something, duplicate search is triggered.

I’ve got fixes out for review that should be merged soon:

github.com/metabrainz/bookbrainz-site

fix(entity-editor): Edition: search for EGs with same name

metabrainz:master ← metabrainz:edition-initial-search-matching-EG

opened 12:15PM - 10 Mar 22 UTC

MonkeyDo

+16 -8

As [reported on the forums](https://community.metabrainz.org/t/more-serious-bug-…concerning-edition-groups/575369/4), when a user creates an Edition with the name pre-filled (for example using the search page call to action), the search for an Edition Group with the same name is not performed automatically, and the user would have to modify the name to trigger it. With this PR, we perform the search for matching Edition Group server-side and add the results to the initial state before sending the rendered page. In a separate PR, I will add the same sort of mechanism to search for duplicates when pre-filling the name

github.com/metabrainz/bookbrainz-site

feat(entity-editor): search for possible duplicates when pre-filling name

metabrainz:master ← metabrainz:search-initial-pre-filled-name

opened 12:53PM - 10 Mar 22 UTC

MonkeyDo

+90 -12

While working on #800 I realized we have the same issue with the duplicate searc…h: When creating a new entity, the search for possible duplicates is only triggered when when user types in the name input. When using query parameters to pre-fill the name of a new entity, that doesn't happen, leading to possible dupes. With this PR we trigger a search for possible duplicates when we render the props to send to the user.

Thanks again for reporting the issues you encounter !