Finding suggestion

itachi_0x0 · December 18, 2023, 1:51pm

hey!! just started contributing to this project . recently finished setting up the project locally and created the first PR on the issue BB-343 on JIRA . you guys can review the request here and I’ll be glad to hear some improvement suggestion :

github.com/metabrainz/bookbrainz-site

other(editor): Integrated the modification of identifiers and aliases into the primary editing workflow

metabrainz:master ← Tarunmeena0901:BB-343

opened 01:09PM - 18 Dec 23 UTC

Tarunmeena0901

+41 -47

### Problem  [BB-343] ### Solution Enhanced main entity editor page: - Introduced an identifier editing section. - Added a section for adding aliases, improving overall editing flow. - Aligned the remove button with identifier rows for a more polished appearance. ### Areas of Impact ~ identifier-editor.js ~ identifier-row.tsx ~ alias-editor.js ~ entity-editor.tsx ![editor-page](https://github.com/metabrainz/bookbrainz-site/assets/97682967/694f6040-4783-4161-af23-433d6be5fcb0)

mr_monkey · December 18, 2023, 3:25pm

Hi @itachi_0x0 and welcome !

Thanks for the PR, I’ll review it when I have a moment.
I’m away from keyboard currently but I’ll be back very soon.

itachi_0x0 · December 29, 2023, 6:00pm

Hello, it’s been a while since I submitted the pull request. Could you please take a moment to review it? I would appreciate any feedback you have, so I can make any necessary changes. Thank you! @mr_monkey

mr_monkey · January 2, 2024, 1:23pm

Hi @itachi_0x0, I’ve been on vacation for the year’s end but I’m back in a couple of days, and your PR is on my radar

itachi_0x0 · January 2, 2024, 2:21pm

oh ok sir i totally understand thanks for your time