Adding work-work relations doesn't work

[indy133]

There’s a bug when trying to add a work-work relationship.

When you click on a work in the relation field you are directed to a non-existent work page every time

[mr_monkey]

Thanks for reporting the issue, I’m looking into it now and it is not redirecting anywhere, just breaking the page completely…

[mr_monkey]

This is now fixed, and I deployed a new version in production.

The issue was with relationship nesting, the code that constructs the hierarchy was bad (I can say that, it was my code ) and only worked for one level of nesting.

We recently reorganized Work-Work relationships and added another level of nesting, and that was crashing the relationship editor.

[indy133]

Thanks, works again and I’ve learned that higher levels of nesting are to be avoided in daily life.

But your repair has a small side effect. When you add a relation (no matter what relation) a list of ‘recently used’ relations appears that gets longer and longer.

I guess that this is not intended

[mr_monkey]

This is a feature, not a bug
This is a new feature that was deployed at the same time, adding the last 10 recently used entities for ease of editing.
Search results still appear below.

Do you think the list is too long? Would you make it shorter?

[UltimateRiff]

looks like there was a ticket for this too (I might have tested after it was fixed, not sure tho… lol), noticed it while collecting tickets for the Beta epic I’ve been putting together

BB-893

I don’t know if the list should be shorter, but it should prolly not be shown when there’s text in the search field, similar to how MusicBrainz does it (and I created a ticket for that too just hours ago, lol). it makes working on series much more tedious, or anything where you’re adding a lot of different stuff to the same entity

BB-895

vs.

for what it’s worth, MusicBrainz also shows the last 10 items, tho 15 could work too, as long as it’s not shown when searching

[indy133]

@mr_monkey

This is a feature, not a bug

Lol…ok….yes..makes sense…and it might be really useful. What made me think this was unintentional is what @UltimateRiff pointed out:

@UltimateRiff

it should prolly not be shown when there’s text in the search field

The constant scrolling gets really annoying when the list is long. This should be fixed.

[atharv002]

Hi all, I am working on BB-895. I think showing recently used only when the search box is empty would work well, similar to how MusicBrainz does it. Another option could be filtering recently used to only show entities that match the search text. Which one do you think would be preferred?

[indy133]

@atharv002

Another option could be filtering recently used to only show entities that match the search text

Thanks…sounds great…because sometimes you push the first letter before thinking if you used the relation recently. Will also be faster, when you used it recently. So I’d prefer this solution.

[spUdux]

@atharv002

filtering recently used to only show entities that match the search text

This, of course

(+20 characters)

[mr_monkey]

This fix has now been deployed, recent results will only show if the search box is empty, or if recent entities match the search term.

Thanks @atharv002 for the quick improvement!