Thanks for that, I hadn’t seen the comments!
I’ve fixed a few more of those bugs/suggestions, and left some more involved ones for later.
metabrainz:master
← metabrainz:fix-album-no-length
opened 01:30PM - 03 Jul 24 UTC
- Sending a `null` or non-integer value for duration_ms in the listen payload re… sults in an error and the listens not submitted.
Reported in the forums https://community.metabrainz.org/t/add-manual-album-listens-offline/696894/19
Thanks Nicknickcdf!
- default durations were not scrolling with the rest of the medium content because of position:absolute without position:relative on their parent element.
- send tracknumber string instead of forcing to integer; the API docs say they expect an integer but track.number in MB is a string and the DB model also expects optional string
- if track duration is not available, use associated recording's duration.
- set the release MBID correclty in `track_metadata.additional_info.release_mbid` instead of `track_metadata.release_mbid`
- display MB `track.number` string instead of `track.position` integer, better for some mediums (cassettes, etc.)
- while doing that, fixed the API docs for `tracknumber` which expected an optional integer, to an optional string as the DB model expects
All of this feedback has been reported on https://tickets.metabrainz.org/browse/LB-1401 or in the forums.
There is one of your comments on the ticket that I don’t understand.
2 Likes
These changes are now live, and submitting listens without duration works, thanks for the report @Nicknickcdf !
I must say, this The Who live album has a distinct lack of tracks from Quadrophenia.
Also implemented more improvements, including some from @kellnerd , than you as well for the assistance.
4 Likes
Was a wicked gig though, lack of quadrophenia tracks notwithstanding! Recording oddity: several power cuts at the liberty stadium. Language was flowery by outage #3 , unfortunately not picked up by the sound board!
2 Likes
That “one minute” trick is great and works for me. As is having the “finished at this time” option. Thanks a lot for implimenting!
2 Likes