Notes from #MetaBrainz Meeting 2021-09-06

[Freso]

MetaBrainz Meeting 2021-09-06

Meeting start: IRC Logs for #metabrainz | MetaBrainz Chatlogs

Colour Blindness Awareness Monday

GLEE - Colorblind (Full Performance) (Official Music Video) HD

Agenda

• Reviews
• MBS-11938: Separate most autoselectable websites into their own relationships
• MBS-6479: Remove option not to be mailed on No votes
• MeB Summit

Last meeting: 2021-08-09
Next meeting: 2021-09-13

Reviews

@zas

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@zas

I did usual stuff, maintenance, supervision, upgrades
but most notably I migrated influxdb + grafana to new server moroder
it cuts a lot of cost of having those on gcloud
I also configured a bunch of new servers (we keep upgrading machines)
I also configured prometheus
the idea is to replace nagios with it (and its alert system)
for now, everything works, but I didn’t deploy widely yet (so only few nodes are providing metrics to it)
I continue on this very soon
plus usual Picard PR reviews and merge

@alastairp

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@alastairp

I was on vacation for 2.5 weeks, it was very nice, although very warm in Barcelona
last week I slowly got back into the swing of things - checking emails, reviewing PRs. With lucifer we released some new versions of CB, including some long-time pending translations
I blogged about the AB similarity feature, nice to see people excited about that!
I worked on a translation of AB javascript code to typescript (thanks monkey for laying the groundwork for this with LB’s configuration files)
I reported a bug in MB’s oauth code to @bitmap and fixed AB/LB/CB in some specific cases
I set up a PR to upgrade sentry to a newer version (this should go out tomorrow)

@mr_monkey

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@mr_monkey

I too was on vacation most of August, and so didn’t get around to doing much work. That was quite nice.
I did keep a close eye on @akashgp09’s project as he successfully finished the GSoC coding period.
After some thorough testing, the last fixes are being implemented now and the project should be ready for beta this week. Congrats !
Since I came back, I started slow with catching up with the many PR reviews that were awaiting.
This includes a new major feature: a notifications system for BookBrainz that prabal —last year’s GSoC student working with BB— started working on.
I also worked on a few small and self-contained tickets for LB and BB to warm up my coding muscles while improving some details, and started thinking about how to scrobble listens when using the ListenBrainz player.

@Freso

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

I’ve had a number of exams and medical appointments these last few weeks, but in between those I’ve dealt with a bunch of reports across MB, forums, and LB - a lot of spam, some users who behaved badly, some sockpuppets, etc.
I also did some blog admin’ing, giving students blog access.
Filed a couple of tickets, some of which @reosarevok has already started on. Also filed a couple of AB tickets, related to new similarity.
And tried to be around and about.

@yvanzo

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yvanzo

I did mentor @yyoung with his GSoC’s project who did successfully complete it; Congratulations again!
Helped students with publishing their final post about GSoC; See GSoC 2021 – MetaBrainz Blog
Restored search indexer on some occasion, helped with debugging SIR using docker-compose.
Released a new version of SIR, thanks to @lucifer and @bitmap; See Release 2.1.1 · metabrainz/sir · GitHub
and @reosarevok too!
(not the release, but the debugging)
Investigated MB load issues caused by consul-template, to be removed by @bitmap with next MBS release.

@reosarevok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

I’ve been working on a ton of smaller stuff for the last few weeks, plus I finished a first pass of the guess case code making it at least typed and more organized
Tons of improvements to be made I’m sure, but it’s a start
Lately I’ve been trying to help with Sir (it being python is not that bad in itself but I’m still not used to sqlalchemy at all, so that’s tricky, but still, I feel a bit less dumb with it than before!)
And helping @Freso with admin tools, as he mentioned
(such as MBS-11866 from today)
Plan for this week is more of that sort of thing, plus finishing some of my kinda embarrassingly long list of PRs that need more work

@ApeKattQuest_MonkeyPython

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@ApeKattQuest_MonkeyPython

For the most part have been pickling and making jams
We changed a styleguide!
Rethinking the [dialogue] guideline
gonna try focusing on bookbrainz this week!

@bitmap

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@bitmap

I worked a lot on GitHub - metabrainz/dbmirror2: Database mirroring system for the MusicBrainz Live Data Feed and dbmirror2 support by mwiencek · Pull Request #2248 · metabrainz/musicbrainz-server · GitHub to move forward on some improvements I’d like to make to JSON dumps and sir (without adding tons of new triggers)
for JSON dumps mostly improving the load issues there and speed of full dumps, for sir we can remove its triggers and rabbitmq
anyway the idea here is to add additional information to replication packets to help determine what columns have changed, but needs more testing
I also made improvements to my PR removing consul-template from MB containers, and deployed that to beta where it’s working fine. will likely release that to prod today as @yvanzo mentioned
otherwise I did some code review and fixed a couple misc. tickets. one to work around another issue causing high load in WS containers that @zas reported.

@akshaaatt

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@akshaaatt

I have started my work on the mb web revamp and for the sake of simplicity and making it convenient for everyone to keep up with the changes, have made it available at GitHub - akshaaatt/musicbrainz-web: Web App of MusicBrainz currently.
I was designing the wireframes, and connecting with the community at
MusicBrainz Web Home Page Mock Ups
I reviewed two PRs, one from @mr_monkey and the other from @jdaok and spent some good time with the development setup.
Other than that, I am on YouTube now and have decided to release a video every week talking about general stuff. This week I talked about MeB and open source!
Link:
https://youtu.be/299HucDKles
It might be the first time you hear or see me live! The video wasn’t scripted so please don’t mind if it feels raw.

@rob

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@rob

I was mostly on vacation, doing lots of hiking and beer drinking in upper franconia (germany).
one hike was literally hiking from brewery to brewery having a beer at each place.
quite fun. about 150km covered in total.
(hiking distance, not beer bottles)
buut, just before I went on holidays, I hired @akshaaatt, who seems to be fitting in nicely. welcome again, @akshaaatt
and while I was hiking I was doing loads of random brainstorming about MeB projects and how to deal with some tricky problems going foward.
and now I have a loong list of stuff to do, not just catching up from holidays, but several projects that need to be moved along.

@lucifer

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@lucifer

I worked on completing the migration to spark parquet dumps in LB and deployed it. I also reviewed some PRs from @jdaok and deployed the Pinned recordings feature. did the usual post deployment bug fixes then
CB API had several bugs which jasondk discovered while working on the mini review features, fixed those to make CB side ready. there were also some CORS issues in CB and LB endpoints worked on fixing them.
other than some misc LB imporvements, CORS, WebSockets, CSRF and login etc.
and finally working on sir debugging for the past few days.

MBS-11938: Separate most autoselectable websites into their own relationships

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

So, with @yyoung’s work, any autoselect-only relationship types no longer appear at all in the dropdowns
So there’s no Discogs, Wikipedia or whatever to be selected if you enter somehomepage.com, and they don’t get in the way
IMO, that removes the only reason to have a catch-all “otherdatabases” entry
And it would make sense to have a relationship for each site in the other databases whitelist, that makes it easier to query for a specific database and whatnot
But before I act on that, I wanted to see if other people see good reasons to keep things as-is
Other Databases Relationship Type / Whitelist - MusicBrainz

@yvanzo voiced that he is against this. He will put down his objection(s) in the ticket and we’ll revisit next week.

MBS-6479: Remove option not to be mailed on No votes

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

Just: is there a reason we have that option at all that I am missing?

It was generally agreed that the option should be removed, but probably as part of a larger effort to make No vote notifications less spammy, e.g., by sending a batch mail listing No votes instead of sending out individual mails for each one.

MeB Summit

IRC Logs for #metabrainz | MetaBrainz Chatlogs

Summit will be online again this year. Potential dates were discussed, with the decision landing on 16th–17th of October as the whole MeB team was available then.

@lucifer agreed to make a wikipage for it.