Notes from #MetaBrainz Meeting 2017-04-17

[Freso]

MetaBrainz Meeting 2017-04-17

Meeting start: IRC Logs for #metabrainz | MetaBrainz Chatlogs

Agenda

• Reviews
• DR: MBS-9113: Incorrect age displayed if death and birth dates are not precise enough
• DR: MBS-6666: Artist credits not renamed from artist edit page unless the artist name is changed

Reviews

@CatQuest

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@CatQuest

this week i had vacation so I didn’t do anything :P.
However want people to read the tread I made a couple of weeks ago:
Instrument Family and Variants Discussion - #3 by reosarevok
and come up with ideas/discussion, naturally you don’t have to do it right now
(to those reading the Meeting Notes on the forum: this means you too! <3)

@Freso

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Freso

This week I dealt with some reported editors (some sockpuppeteering).
I also updated Discourse, but mostly I was deep into ROD 2017 - MusicBrainz so I didn’t do all that much.
(I did manage to keep up with IRC and forums though.)

@reosarevok

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@reosarevok

implemented the feat. guideline changes, and having actually got something done for once, immediately went on holiday
So I was in Latvia for the weekend, just got home a few hours ago, catching up on subscriptions
Caught up on support too
Plan for next week is to actually move forward with the events guideline. Which, yes, was the plan for this week.

@Quesito

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Quesito

last week I continued the invoicing madness through to mid-week.
then I needed to take a break, as it was making me cranky.
We are making progress though in the accounting world!
Hopefully this week we make it though the euro folks
We also welcomed a new bronze supporter!
and then I tried to doing some visual stuff for our verbiage changes and data visualizations

@Rob

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Rob

I spent the first part of the week focused on stress taking listenbrainz.
I found two problems and set out to fix them. It seems fine now, but influx can behave kinda badly when pushed too hard, but seems solid just short of that. something to keep in mind.
I moved to using RabbitMQ for messaging, which is working well. I hope to finish that PR tomorrow.
@Gentlecat, @bitmap: After these findings, I’m certain we can use both the existing redis and rabbitmq – the use of it even with a few M listens seems to be minimal.
I’ll update syswiki accordingly.
@zas: we’ll need to keep an eye on influxdb and at the first growth spurt, we’ll need to get it a 128GB server.
(@bitmap says: «there’s clustering support too afaik if we need it»)
yes, which all gives a nice growth path, so I am satisfied that we’ve not setup ourselves up for a massive fail within days of launching our beta.
(famous last words)
I also kept talking to a potential customer who is taking quite a bit of effort to signed up.
today I did out tax prep for our accountants, which actually went pretty smoothly. Our books are looking cleaner than ever, now that I have help and a second set of eyes on things.
shit now has to make sense to Quesito as well.
of course, the second I sent the docs, just on deadline, I get an email from my accountant: I’m off, sucker! See ya next week.
Sigh.
at least they’re done.
back to LB tomorrow. once the rabbitmq PR is merged, I’ll spend time to update jira and figure out what needs to be done before we go to beta. iliekcomputers and I are going make that our very short term focus now.

@ferbncode

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@ferbncode

This week I worked on improving code in old PRs and opened up pull request for migrating licenses.
Working on the last two models for CB-230.

@zas

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@zas

Well, i was visiting friends a good part of the week, so mostly competing for the slacking contest
But i did usual reviews/merges, server maintainance & supervision (sorry, no issue, apart lemmy… thanks to ruaok
And of course a bunch of MB edits

@bitmap

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@bitmap

I did the mbs release, a few days late (sorry)
and I finally updated the syswiki docs for how to do releases, with the docker changes
fixed all the test failures and more bugs in Add a plugin to embed React components within TT by mwiencek · Pull Request #502 · metabrainz/musicbrainz-server · GitHub
I’m thinking of merging that to beta this week and skipping the next release (would be the last before the schema change anyway)
so there’s more time for people to find template issues
other than that I worked on the work-languages schema change UI and did code review

@Gentlecat

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Gentlecat

I spent a bunch of time reviewing GSoC proposals
also checking PRs for CB, most of which were merged and deployed today
continued some work on payments in MeB.org
upgraded sentry and jenkins

@yvanzo

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@yvanzo

Last week has got colder.
I mostly reviewed my own code for entity attributes, again.
The more it makes progress, the more I can see shortcomings of work attributes.
But improving over it without altering existing tables is meh too, so I am splitting changes for Q2 and Q4 schema changes.

There was also a small bit of discussion about the specifics of these changes.

@Sophist

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@Sophist

Not much to report - rewrote two Picard plugins for better functionality, reduced scope on Picard support for iTunes Classical tagging (to reading and writing the tags but not populating them with data - Apple decided to do it in a way that is essentially incompatible with existing industry-wide use of tags inc. Picard - D’oh).
A few comments on these I need to sort out.
Not even close to the slacking trophy - just other real-life work.

@samj1912

IRC Logs for #metabrainz | MetaBrainz Chatlogs

@samj1912

So last week I updated the plugins repo to build 2.0 plugins, did the same on PW side and picard side and updated some of the plugins to 2.0 , the new plugin display page can be found at Available Plugins - MusicBrainz Picard and v2 plugins @ https://picard.musicbrainz.org/api/v2/plugins , I also fixed a couple of picard bugs and added a couple of tests
College quizzes took time this week and so did 3 lab assignments which as ongoing, will be free to code after the 22nd

DR: MBS-9113: Incorrect age displayed if death and birth dates are not precise enough

IRC Logs for #metabrainz | MetaBrainz Chatlogs

There was general consensus about going with @chirlu’s second listed option on the ticket, «Detect ambiguity and say something like “circa 61 years” or “60 or 61 years”.», leaving the exact wording to whomever actually makes a PR implementing it.

DR: MBS-6666: Artist credits not renamed from artist edit page unless the artist name is changed

IRC Logs for #metabrainz | MetaBrainz Chatlogs

Consensus for «hide/disable these controls when there is no change to the artist name».