This is a monster one really, around 200 credits and 600 rels. Script did really well here.
It seemed to interpret “Technician [Technical Support Team]” as Instruments instead of the Instrument Technician credit type on MBz.
Just report anything you find on issue tracker and I will take a look
There is an equivalence set writer composer. I could add lyricist in the set. When any item from the set is already present, script will skip adding other items from the same set.
I don’t invent names, the name of the track is used, so it shold be fixed.
Isn’t type automatically set to Song? In any case, params of new work are easy to fix, but setting Language is probably user specific. Maybe we should have script options for work defaults.
Maybe a little visual prompt to tell people they need to set these manually?
When you use script like this its expected to double-check everything. There are hundreeds of things I could worn about
Perhaps adding an option to remove credit in review phase should be done. Currently, you can unset any artist to do that, but it will skip all its credits, and in this case you might want to remove only musician. In any case, I opted for after the fact fixes and provided batch removal tools for that - shift click button (x) nexto to “instrument” role and remove it from all tracks at once. Maybe its not flexibile as review table phase removal though…
i think it was closer to
I don’t understand what you mean?
I’m not saying you’ve invented anything. You need to make sure that what is being imported follows the style guidelines as mentioned here Style / Miscellaneous - MusicBrainz - replacing "’ ’ " with " ’ " along with that the capitalisation needs to follow the style guidelines too Style / Language / English - MusicBrainz .
Discogs wants every single letter of every word regardless of language capitalised, which we don’t do and in general we have different rules for different langauges anyway. Again this could be sorted by having some settings that can be toggled for when works are created, otherwise we’re just making more work to go in there and fix these things later.
No, by default a work will create an entity without a Type or Language field. Yes a script options for the work creation section would solve this.
Indeed but you need to appreciate that anyone could use your script and cause a lot of bad edits, and as there are no hard restrictions for true newbie editors at the moment anything that can slow this down is generally appreciated. A lot of the time these mistakes aren’t made maliciously, they’re accidental and could be avoided if there was some guidance within the UI that suggested everything is double-checked.
Yep, ultimately this is an edgecase. I don’t recall seeing many releases on Discogs where someone has for example added “drums” and “musician” because even in Discogs-land that makes zero sense. Musician/instruments/performer is to be used when someone is credited without specifying what instrument they play, if an instrument is mentioned then that instrument credit should be used instead.
I’m going to try with some simpler Discogs entries instead of a 350+ credit mess like that Quincy Jones one, and see how it fairs 
Please don’t take any of this as me disliking the script, I think it’s really good - but you’ve demonstrated just how difficult it is to make Discogs’ credit style fit MusicBrainz credit style 
I mean work name is created based on recording name - if it follows the guideliness, work will.
OK, my bad, then I would probably go with more options…
Yeah, I thought so, which is why it probably doesn’t deserve implementation. Although, this is more or less trivial, just need to think about broader functionality. There was also a request to add date on relation in review phase so maybe we could have detailed setup per relation. Its probably gonna be overkill though for 99% of cases.
You can dislike it as well, no hard feelings. You have rights to say whatever you want and me 2 accept it or ignore it.
Thanks for detailed notes. If you go into this level of detail I suggest keeping ideas/notes organized via Github discussions.
I don’t think any import script does this. I use standard Discog Release import scripts. This does not correct any of the Discoggian Capitalisation. It is down to the person running the script to do that. (I assume same with Harmony?)
It is more usual to use Guess Case yourself and then clean up. The script is just grabbing the data as it stands.
Yes, Harmony et al. don’t fix these sorts of errors either. I wouldn’t expect them to, the guidelines are complex and language dependent.
I agree with @sound.and.vision that everything should be made to avoid defaults that would generate many things to be fixed.
I think Harmony does some for the digital seeding - then again I’m so used to being in the Release Editor window and hitting the Guess Case and the Guess Punctuation (userscript) buttons that I don’t really know what Vanilla MBz workflow is anymore 
edit: oh the post below this one states that even Harmony doesn’t do that
Yes, please do that, nice script btw… keep up the good work, I know how much work is involved …
Ty @vzell, it all started with your script.
I intentionally didn’t add lyrics to equivalence set as I noticed that, at least in my tryouts, the problematic stuff was adding writer when composer was already present. Writer doesn’t to me equal to lyricist, but if other people think so, I can add it.
I envisioned sets to be configurable so anybody can modify them, but I wanted to see if enough people wil complain to deserve implementatinon …
so generally the idea (unless im wrong) is that written-by is when there is no distinction made as to who wrote the lyrics vs who wrote the melody. This is more common now, and certainly in “pop” music.
Lyrics By/Composed By is often really only used when it is explicitly known who wrote what, and is generally more common in older pop music and styles of music like Jazz.
I’ve just opened my first Issue, hope this helps
On that example, I’ve also ran into this but I’m unsure what this instrument might mean/be - anyone else got any ideas what this could match to in MusicBrainz (except the obvious “bass”)?
Brass Bass, Bass [St Bs] –
Hayes Alvis
OK, will take a look.
In advance, please Copy Log and paste it into an issue.
Here is another case where performer credits didn’t work: Release “Piano Concertos Nos. 25, K.488 & 24, K.491 • Concerto For Two Pianos And Orchestra, K.365” by Mozart, Robert Casadesus, Gaby Casadesus, George Szell, Eugene Ormandy - MusicBrainz / https://www.discogs.com/release/10393434
I would expect these artists to be assigned to the tracks 1-3:
@VBZPPlNQyJ, you can try it again, fixed.
