Thank you for the wonderful Classical Extras 0.x. I have been using various versions on all my classical music tagging for several months.
I’ve been having difficulties using Picard and Classical Extras 0.9.3 to update the tags in my 1984 Solti Götterdämmerung Release (release/4ded9). Some problems occur with Classical Extras turned off. But when I turn Classical Extras on, I see many repetitions of the following error:
E: 23:49:14 Traceback (most recent call last): File "picard/album.pyo", line 330, in _finalize_loading_track File "picard/metadata.pyo", line 351, in run_track_metadata_processors File "picard/plugin.pyo", line 479, in run File "/Users/jdlh/.config/MusicBrainz/Picard/plugins/classical_extras.zip/classical_extras/__init__.py", line 4153, in add_work_info File "/Users/jdlh/.config/MusicBrainz/Picard/plugins/classical_extras.zip/classical_extras/__init__.py", line 550, in get_options KeyError: u'/Volumes/Qmultimedia/Music/master_tagged_files/Wagner, Richard; Vienna Philharmonic, Solti, Georg, Sir/Go\u0308tterda\u0308mmerung (feat. conductor_ Sir Georg Solti)/409 Go\u0308tterda\u0308mmerung_ War das sein Horn_ (Gutrune).flac'
I did a little investigation. Here are some observations.
- The KeyError seems to come from Classical Extras looking up
track_fileseems to have been assigned the value
- Note that the FLAC file’s path includes
u'a\u0308'. \u0308 is U+0308 COMBINING DIAERESIS.
- I am running on a Mac (Mac OS X 10.11.6). I understand that on the Mac, filenames are stored in Unicode’s Normalisation Form NFKD, fully decomposed. (Source: Apple TN1150, “HFS Plus defines that Unicode strings will be stored in fully decomposed form, with composing characters stored in canonical order.”)
- I speculate that maybe
album_file.filenamehad the ö and ä characters in composed form, which is a different set of character codes than the HFS+ filesystem’s decomposed form.
If my speculation is right, you might be able to reproduce this by giving a music file a name with ö and ä characters and running Picard 1.4 + Classical Extras 0.9.x on a Mac OS X 10.11 system. If I recall correctly, 10.12 introduced a new file system which might behave differently.
I hope this report is helpful. Please let me know if you’d like me to turn this into a Issue on the Classical Extras github repo.
You have published Classical Extras 2.0 (thanks!). I balked at trying it because you label it as “beta”. I could give it a go, however, if you think it might help.